Repository navigation
Conversation
Cancellation request counts omit whether their waiter was cancelled or replaced. Fixed booleans distinguish those states without recording private task content. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1072
Related: #1025
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Not required.
Why
A failed claim cancellation can leave a task with one cancellation request while it still waits for input. The failure trace needs the waiter's state to distinguish a consumed request from a cancelled waiter awaiting its task's next step.
Scope and risk
Only the claim cancellation test's failure observer changes. It records fixed task and waiter booleans, plus the pending cancellation flag when the runtime exposes it. Task names, arguments, local values, input and exception content stay out of the packet. The existing task, frame and byte limits remain.
This adds diagnostic evidence; it does not establish or repair the cancellation failure's cause. The command, signal tests, stdin behavior, lifecycle assertions and exit deadlines are unchanged.
Compatibility, rollout and rollback
Tests
Two isolated controls fail with missing observer fields before the change and pass after it. They distinguish a cancelled waiter before task resumption from a consumed cancellation followed by a fresh waiter.
The five selected observer and privacy cases pass. Scoped Ruff, format, prose and whitespace checks pass. An AST comparison verifies that every existing test and helper except the observer is unchanged, that all original assertions remain, and that the two new controls match their failing versions.
Full hosted CI and a fresh independent review are required after publication. The natural signal race and the claim subprocess tests were not repeated locally.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the observer fields and isolated controls. The source diff, regression failures, focused results and preservation proof were checked.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist