Repository navigation
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category
Changelog entry
Not required.
Why
The grep fallback test requires a request to reach its local HTTP server even when its deadline can expire before dispatch. A controlled delay demonstrates that native output and exit status remain correct while that assertion fails.
Scope and risk
Two test files separate transport timeout coverage from response handling. The existing HTTP cases retain their three modes, mode order, native output and exit checks, 300 ms request deadline and 3000 ms elapsed bound. Their unconditional request-arrival assertion moves to deterministic child-process response cases.
A test-only preload supplies real refusal and malformed JSON response objects before the shim deadline begins. The cases require request invocation, validate the request and record whether JSON parsing ran and rejected. Copies that ignore the response status or JSON parsing fail those controls. Existing successful annotation cases still exercise the real HTTP path.
The historical macOS failure has no transport-phase trace. This fixes the fixture contract without claiming a measured scheduling cause or a production defect.
Compatibility, rollout and rollback
Tests
AI assistance in the code
AI-generated: Codex investigated the fixture, wrote the response controls and checked the unchanged timeout boundaries.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist