Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
fix/hook-contract-sandbox-drain
branch
from
November 20, 2026 23:43
f1a5ac7 to
334a924
Compare
2 of 4 tasks
zlareb1
force-pushed
the
fix/hook-contract-sandbox-drain
branch
from
November 21, 2026 00:04
334a924 to
e9a7dd2
Compare
Keep each test sandbox until its detached flusher removes its final job marker. Preserve hook deadlines and verify unfinished jobs refuse cleanup. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/hook-contract-sandbox-drain
branch
from
November 21, 2026 01:24
e9a7dd2 to
4415724
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category
Changelog entry
Not required.
Why
Hook contract tests remove their sandbox after the immediate hook exits. A detached flusher can still be writing there. The fixture waits for its owned job files to disappear before removing the sandbox; the flusher removes each job after its cursor and recording writes.
Scope and risk
Only the hook contract test's six cleanup sites and a test helper change. A controlled detached writer demonstrates premature removal, and the real flusher runs behind a response barrier. An unfinished job fails cleanup after a separate 45-second teardown bound. There is no removal retry, disabled delivery or production hook change.
All existing cases, inputs, concurrency, output assertions and measured hook deadlines remain byte-identical. The original hosted failure's particular late writer remains unknown; the regression proves the reachable ownership race.
Compatibility, rollout and rollback
No wire, settings, plugin version, shipped hook or operator changes. Reverting changes only test cleanup.
Tests
All six selected hook cleanup, unreachable-server and isolated-home import cases pass on this composition. Syntax, Biome formatting, public prose and committed-range whitespace checks pass. The source tree equals the expected three-way composition with main; every prior concern file retains its exact Git blob and mode. The earlier full CI result belongs to the previous public head. This head requires a new independent whole review and full hosted CI before merge.
Prior-head source evidence
The extracted original cleanup fails two regression cases and passes the empty-job control. All four cleanup cases pass after the fix, including the real detached flusher and unfinished-job refusal. The original unreachable/unauthorized/hanging-server contract case and suite-wide isolated-home import contract also pass with their unchanged assertions. New child processes use the existing cross-platform environment helper. Scoped syntax, Biome, prose and whitespace checks pass. Full hosted CI and fresh independent whole review are required before merge.
AI assistance in the code
Checklist