Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
test/linear-cost-sample-context
branch
2 times, most recently
from
November 21, 2026 00:04
9bb65e3 to
4541d35
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep each test sandbox until its detached flusher removes its final job marker. Preserve hook deadlines and verify unfinished jobs refuse cleanup. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 2e63764) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 334a924) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
test/linear-cost-sample-context
branch
from
November 21, 2026 01:23
4541d35 to
be775cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1090
Changelog category (leave one):
Changelog entry
Not required.
Why
Linear cost failures need each sample's process state to distinguish a changing measurement regime from growing parser work. Selected minima alone omit the samples the judge did not select.
Record process, wall and thread clocks, allocation counts, GC state, and tracing/profiling state around each original sample. Scalar checks and the independent lane-walk child retain all sample values and their order. Registered lanes retain their sample values and boundary context. The direct SQL ratio check opts into the same context through its existing CPU helper. Failure output encodes the complete context as JSON.
Scope and risk
The hook-contract prerequisite waits for owned detached-flusher completion before removing its sandbox. Its original hook deadlines and assertions remain unchanged. The fixture uses the existing isolated-home import and cross-platform child environment helper. This addresses a separately reproduced teardown race, with no production hook change.
Related person-query fixture changes keep observations scoped to the authorization decision. Focused checks also verify the isolated write leases for the replicated erasure fixture and its unit companion already on main. Their finite-budget, replicated-content and missing-store controls stay intact. No production lease or authorization rules change.
Observation runs outside the original timed cost calls. Boundary deltas include observer work and, for lane walks, registered lanes and SQL, collection and tracer restoration. Observer work and allocations can perturb later calls; these fields are diagnostic context, not a new cost measurement or acceptance criterion. Input text and exception messages are omitted. A context collection error records its class without changing the judge.
The independent lane-walk child emits one packet containing the same two CPU minima and all six ordered samples. Its parent preserves the comparison, floor, subprocess deadline and failure behavior. Input sizes, call order, sample count, min selection, warmup and retry policies remain unchanged. The causes of the Python, Lua, SQL and setup.cfg cost failures remain unknown. This change claims no parser performance fix.
Compatibility, rollout and rollback
Wire changes and operator steps: none. Reverting changes only test code.
Tests
All 47 directly related diagnostic, helper, judge, fixture and single SQL cases and six hook cleanup cases pass on this composition. Scoped source formatting, lint where applicable, public prose and committed-range whitespace checks pass. The source tree equals the expected three-way composition with main; every prior concern file retains its exact Git blob and mode. The earlier full CI result belongs to the previous public head. This head requires a new independent whole review and full hosted CI before merge.
Prior-head source evidence
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the diff and checked the timing boundaries, unchanged judges, focused regressions and AST comparisons.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist