Repository navigation
Conversation
Keep all four submissions in the same logical window so the test exercises close flushing pending writes before the transport closes. Preserve the existing inputs, scheduling yields and result assertion. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 96be03c) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 of 8 tasks
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1066
Related: #1077
Changelog category
Changelog entry
Not required.
Why
The close test assumes four scheduled writes enter one coalescing window. Scheduling pauses can split those writes into separate windows, leaving no batch for close to drain. Holding the loop clock still establishes the intended burst while the real close method remains responsible for flushing it.
Scope and risk
The existing ManualClock controls only this test's loop clock. All four writes, both scheduling yields, the close call and the original result and bulk-write assertion remain. Production coalescing, deadlines and transport behavior do not change.
The branch contains the erasure lease fixture from #1077, which is already merged. The merge result changes only the close test clock.
Compatibility, rollout and rollback
Tests
AI assistance in the code
Checklist