Repository navigation
Conversation
Keep OS return codes distinct from pytest status and label observations taken after existing worker teardown. Retain bounded artifacts and job-log evidence without changing test outcomes. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Add a collection budget operation and Library control while preserving the namespace registration guard and existing budget enforcement. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep the unavailable action discoverable and declare the existing inbox ownership check in the scope contract. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Loading a policy cannot have committed a save, so reserve write uncertainty for failed updates. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep classification and unknown columns through the existing full-row read. Retain failed read-count assertions and include request details for diagnosis. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Fenced memory inserts require a lease table in the selected schema. Give each fixture database its own Keeper root while preserving the replicated content checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 96be03c) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
4 of 5 tasks
Keep all four submissions in the same logical window so the test exercises close flushing pending writes before the transport closes. Preserve the existing inputs, scheduling yields and result assertion. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 5a15b56) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1077
Related: #1085
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Collection admins can set collection and per-user spend caps and a budget warning inbox from the Library.
Why
Budget enforcement reads collection policies, but collections have no operation to change them.
namespace.registercorrectly rejects collection changes. Add a collection-specific operation and an admin control that save only the requested budget fields.Scope and risk
The branch contains #1065, which is already merged. The merge result adds no worker diagnostic changes. The erasure lease fixture in #1077 is already merged. The close-test clock fixture in #1085 must land independently before this PR merges.
collection.budget_setrequires admin access to the addressed collection and is audited. It rejects personal, missing and retired collections, and warning inboxes owned elsewhere. The directory claim covers the read and write; the stored row carries every unrelated field forward. Existing spend accounting, grant checks, enforcement thresholds and thenamespace.registerguard keep their current behavior.The Library reads the current policy before saving, retains failed drafts and closes the form on scope or role changes. The SDKs, operation reference and reach manifest are generated from the operation declaration.
Compatibility, rollout and rollback
collection.budget_setwith optionaldaily_cost_cap_usd,daily_user_cost_cap_usdandbudget_alert_inbox. Omission preserves the stored field; explicit null is rejected. A zero cap inherits the deployment default; an empty inbox disables warnings.Tests
CollectionOps.budget_set.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex. Source review checked the write authorization, policy preservation, generated changes and focused regressions; fresh independent review runs on the pushed head.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
make format-check,make lint,make typecheckandmake test-unitpass; the integration suite passes if server behaviour changed.