Skip to content

Drive retirement cancellation checks with a private clock - #1053

Open
zlareb1 wants to merge 2 commits into
mainfrom
fix/retirement-request-clock
Open

zlareb1 wants to merge 2 commits into
mainfrom
fix/retirement-request-clock

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Changelog category

  • CI Fix or Improvement

Changelog entry

Not required.

Why

The retirement cancellation test waits for handler entry with a half-second deadlock watchdog. Keep the cancellation protocol’s timers on a private loop whose clock advances during idle waits, independently of CPU scheduling latency.

Scope and risk

The included person-query observation fixture scopes captured queries to the authorization decision task. Its unbounded-read negative controls remain intact. The replicated-erasure lease fixture and regression are already on main and are preserved unchanged. No production authorization, lease or erasure rule changes.

The retirement change touches one unit-test file. Only the cancellation test and its blocked-wait control use the private function loop. The control verifies that an unfinished wait still times out after half a second. Fixture teardown drains and rejects newly pending tasks.

Every existing test body, assertion and deadline value is retained. Product behavior and shared test helpers are unchanged.

Compatibility, rollout and rollback

  • Wire, schema, configuration and operator steps: none.
  • Rollback: revert the fixture change. No persisted data changes.

Tests

  • .venv/bin/python -m pytest -q tests/unit/test_cell_retirement.py: 34 passed.
  • The directly related erasure-fixture and person-query observation controls pass all 13 cases.
  • Scoped Ruff lint and format checks, existing test-body comparisons and diff whitespace checks pass.
  • These results are from the composed head. The prior hosted setup-configuration linear-cost failure remains unexplained; this fixture composition makes no claim to repair that separate gate.
  • Full exact-head hosted CI and a fresh independent whole review must pass before merge.

AI assistance in the code

  • AI-generated: Codex wrote the fixture change and checked its clock boundaries, cancellation controls and task cleanup.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Existing assertions and deadline values are retained.
  • No production code, generated interfaces, migrations or operator settings change.
  • Commits are signed off.
  • Full exact-head GitHub CI passes.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 12:21am UTC

Request Review

@zlareb1
zlareb1 force-pushed the fix/retirement-request-clock branch 3 times, most recently from d3a956f to fe4fc36 Compare November 20, 2026 23:03
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/retirement-request-clock branch from fe4fc36 to 9c2cc35 Compare November 21, 2026 00:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant