Repository navigation
Pin lexical timing in stage-wall payload comparisons - #1055
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/search-payload-clock
branch
from
November 20, 2026 20:31
48b227f to
0506ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1053
Changelog category
Changelog entry
Search payload comparisons use the same controlled clock as lexical stage accounting.
Why
The payload comparison removes stage timing fields but retains lexical timing. Measuring that value against the host clock makes equal payloads differ with scheduling. Bind the lexical helper to the fixture clock so the assertion compares behavior consistently.
Scope and risk
One unit-test fixture changes. Production search, payload fields, timing assertions and latency limits are unchanged.
Compatibility, rollout and rollback
No wire, settings, storage or operator changes. Reverting the fixture needs no migration.
Tests
All nine stage-wall cases pass on the composed head. Full hosted CI remains required.
AI assistance in the code
Checklist