Skip to content

Pin lexical timing in stage-wall payload comparisons - #1055

Merged
zlareb1 merged 1 commit into
mainfrom
fix/search-payload-clock
Nov 20, 2026
Merged

zlareb1 merged 1 commit into
mainfrom
fix/search-payload-clock

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: #1053

Changelog category

  • Bug Fix

Changelog entry

Search payload comparisons use the same controlled clock as lexical stage accounting.

Why

The payload comparison removes stage timing fields but retains lexical timing. Measuring that value against the host clock makes equal payloads differ with scheduling. Bind the lexical helper to the fixture clock so the assertion compares behavior consistently.

Scope and risk

One unit-test fixture changes. Production search, payload fields, timing assertions and latency limits are unchanged.

Compatibility, rollout and rollback

No wire, settings, storage or operator changes. Reverting the fixture needs no migration.

Tests

All nine stage-wall cases pass on the composed head. Full hosted CI remains required.

LOOM_ENV_FILE= .venv/bin/python -m pytest tests/unit/test_code_search_stage_wall.py -q

AI assistance in the code

  • AI-generated: Codex prepared the fixture repair and composition. A fresh independent whole review and exact-head CI gate merging.
  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full hosted CI passes on this head.
  • Assertions and production deadlines remain unchanged.
  • No generated files or operator steps are required.
  • Commits are signed off.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 20, 2026 8:33pm UTC

Request Review

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/search-payload-clock branch from 48b227f to 0506ed4 Compare November 20, 2026 20:31
@zlareb1
zlareb1 merged commit 2989750 into main Nov 20, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant