fix(integrations): serialize same-connector mutations - #3336
Chris0Jeky wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67aed3cfd0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Parent reconciliation required before any further qualification. PR #3332 now ends at Keep this third-level child draft and treat its current non-mergeable state and prior CI as superseded. After #3329 and #3332 are integrated, rebuild the mutation-ordering delta on the corrected parent, verify the child-only diff, and rerun the complete matrix and review. |
|
Handoff: this child is fully saved at |
Closes #3334.
Stack
Stacked on PR #3332 (
audit/3331-integration-session-ownership), itself stacked on #3329. The current merge base is corrected parent head4a18108e3fd9dec6b2edadd176461c414f734369; compare confirms the child is ahead with only its four mutation-ordering files.Summary
Serializes update/delete/enable/disable work per connector ID while preserving independent-connector concurrency:
Delete remains ordered rather than magical: later intent may still reach the server and receive NotFound. This preserves one client’s submission order only and does not solve cross-device concurrency without a backend revision contract.
Test-first and review evidence
ade79cd4ceac6ca3f3130ba1765039bbfbc0337aecae7bd64f55f26b572bd22486fbe0e3bc7264a667aed3cfd07ec6317b0d46a6cd998e2a402248f7ed2edaee632f3fe67934dd15645750ec83a4455126973971495bf19d55328a2daaf7b46499e507e6The original negative control produced five expected failures while the different-connector concurrency control passed; all six ordering schedules passed after serialization.
Codex review found that connector 1's queued mutation could erase connector 2's failure when transport began. The new deferred Pinia case makes connector 2 fail while connector 1's successor waits, then asserts connector 2's receipt survives both queued start and success. Error receipts now carry the token that produced them, and queued work can retire only its own predecessor's token.
Prior qualification
Initial head
67aed3cfd07ec6317b0d46a6cd998e2a402248f7passed Self-Test35599938032, Extended35599938236, and Required CI35599938601. Those runs predate the review correction and corrected parent.Exact-head CI and repeat independent review are required at
26973971495bf19d55328a2daaf7b46499e507e6. Keep draft and stacked until inspected. After #3329 and #3332 land, retarget to currentmain, verify the child-only diff and rerun qualification.Green CI is not merge authorization. No merge, release or deployment qualification is claimed.