Skip to content

fix(integrations): invalidate mutations on session replacement - #3332

Draft
Chris0Jeky wants to merge 11 commits into
mainfrom
audit/3331-integration-session-ownership
Draft

Chris0Jeky wants to merge 11 commits into
mainfrom
audit/3331-integration-session-ownership

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Closes #3331. Related residual: #3352.

Stack

Stacked on PR #3329 (audit/3327-integration-read-ownership). Retarget to main only after #3329 lands, verify the child-only diff, then requalify. Same-connector mutation ordering remains in stacked PR #3336.

Summary

Connects integration reads and mutations to the real session lifecycle:

  • identity/auth/demo replacement clears connector list/detail and retires all work;
  • same-user token rotation preserves settled list/detail data and suppresses old-token settlement;
  • active empty list/detail reads restart under the new token, retaining the exact connector ID;
  • register/update/delete/enable/disable cannot patch a replacement lifetime and are never replayed;
  • stale mutation failures cannot set error or emit toast;
  • original transport promises still settle to their callers.

Test-first evidence

The original child suite covers cache clearing on logout, same-user relogin, stale register, same-ID update/delete and stale mutation failure. A bounded actual-module runner changed from 0/5 passing on the parent to 5/5 passing after the first lifecycle correction. Review-regression head 9934e9f029e8942575040f07a76f7b42e0946f37 ran canonical Ubuntu/Windows qualification; Ubuntu JUnit recorded 7,163 tests, exactly 2 failures, 0 errors, both loaded-cache preservation schedules.

Issue #3352 added test-only head 03f46771c7e4e128542331ba1aba2a5089b3a023, covering token rotation while list and detail are still empty. A dependency-free actual-module runner changed from one API call per lane with loading false to two calls per lane with old settlement suppressed, the same detail ID retained, and fresh results installed.

Supplemental execution does not replace hosted qualification.

Current head and remaining gates

Exact final head: 636953f3592e972743df8d1ec3577b76e63545a9

Keep draft and stacked until this exact head passes Smart CI, Extended and the complete Required CI matrix, followed by fresh review. After #3329 merges, retarget, verify the child-only diff and rerun qualification; then reconcile #3336.

Green CI is qualification evidence, not merge authorization.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T14:11:29.813725Z ade79cd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky
Chris0Jeky marked this pull request as draft September 21, 2026 14:15
Base automatically changed from audit/3327-integration-read-ownership to main September 22, 2026 00:52

Copy link
Copy Markdown
Owner Author

Continuation integration checkpoint: parent #3329 is merged as f3af57a, and GitHub retargeted this child to main. New child head 404a311 is a normal two-parent integration commit retaining 636953f and current main, with no force push.

The advertised synthetic merge e87c4db still had the old parent 4e232e2, so its tree was deliberately not used as current-main evidence. Compared old parent to current main: no overlap in the four child paths. Reused the exact existing child blobs on current main's tree. Final GitHub compare confirms exactly the four-file child diff (101+/31- store, 171+ session tests, 168+ token tests, 43+ note), preserving all intervening main changes.

Keep draft until this new integration head has complete exact-head CI and final review; old parent/source runs do not qualify it. #3336 remains stacked after this corrected lifecycle parent and must be reconciled after it lands. This checkpoint is integration preservation, not a new claim of full child code review, local runtime validation or merge readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

Integration mutations and cached connector state outlive session replacement

1 participant