Repository navigation
Batch tensor I/O in checkpoint serialization - #76
Closed
sharmis-tp wants to merge 1 commit into
Closed
sharmis-tp wants to merge 1 commit into
sharmis-tp wants to merge 1 commit into
Conversation
CanReader
force-pushed
the
fix/checkpoint-bulk-io
branch
from
November 12, 2026 08:57
124a0b8 to
5cc8feb
Compare
4 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
Problem
save_tensorsandload_tensorswrite and read each f32 value individually -- onewrite_all(&value.to_le_bytes())orread_exact(&mut [0u8; 4])per element. On large models this is a lot of tiny calls even with buffered I/O.Fix
Collect each tensor's values into a single byte buffer and issue one
write_all/read_exactper tensor. The on-disk format is unchanged (same little-endian f32 layout).Test plan