Repository navigation
Batch tensor I/O in checkpoint serialization - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
save_tensorsconverts each tensor to bytes once and writes it with one call;load_tensorsreads a tensor's bytes with one call and decodes them. The on-disk format is unchanged.Why
This is #76 rebased across #74, which moved the body of
save_tensorsinto the atomic-write closure and left #76 conflicting. The contributor's commit is kept as is with their authorship; the second commit iscargo fmt. Landing it from a branch in this repository because the fork's branch cannot be updated from here.Closes #54.
How it was verified
cargo testpassescargo clippy --all-targets -- -D warningsis cleancuda_parityon a GPU--releaseSerialize unit tests, robustness and safetensors suites pass locally on the rebased result; CI runs the rest.
Checklist
tensor/opsandautograd/opsstill mirror each other///docs