Regenerate for needs_approval's new signature, and readiness at 6,080 - #26
Merged
Merged
Conversation
Pairs with ctrlrun#191, which builds two of SPEC-v0.10 §9.4's three rows. `needs_approval` now takes `task=` and `hop=`, so its API page picks up the signature and the paragraph saying what they are for. `banner.mdx` moves with it because the two share a source line range. Readiness 6,070 to 6,080. All seven generators, 19 recipes 0 drifted, 83 pages, claims re-pointed 0 unresolved 0, and the kernel worktree came back clean after the cookbook write.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…y did `render_readiness.py`'s docstring calls `--check` "what CI runs". CI did not run it. That is the sentence one level up from the comment beside the audit step: a guard CI does not run is prose. The count is the one figure on the site that is a **measurement** rather than a claim, and nothing in CI re-took it. `test_the_readiness_block_is_the_generators_in_every_place_it_appears` compares the embedded block against the stored `generated/readiness.json`, so the page and the state file agreed with each other while both drifted away from the library. Today they are four apart: the site says 6,066, ctrlrun `main` collects 6,070. **It cannot flap between a paired kernel and docs merge**, which is why it is safe to add mid-stack. The count is a floor: `--check` fails when the suite has *fewer* tests than the page claims and passes when it has more, so a kernel PR that adds tests leaves docs `main` green until its docs pair lands. Verified both ways against real checkouts -- docs `main` against kernel `main`: 0 drifted; this branch against ctrlrun#191: 0 drifted. `test_ci_runs_the_three_checks_and_the_drift_check` reads the workflow, so the list and the job cannot disagree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with ctrlrun#191, which builds two of
SPEC-v0.10 §9.4's three rows. Same branch name onboth sides, so CI here checks against that kernel branch rather than against
main.Replaces ctrlrun-docs#25, whose kernel pair was merged out from under it, the branch it was
named for no longer exists, so its check would fall back to
mainand fail on a count that is tenahead. #25 should be closed rather than merged.
What changed
ctrlrun.adapter.needs_approvalnow takestask=andhop=:Its API page picks up the signature and the paragraph saying what they are for: without them the
predicate evaluated against the receiver's whole candidate set while
executeevaluates against thehop alone, so it answered "a human is needed" for a call
executethen refuses.banner.mdxmoveswith it because the two share a source line range.
Readiness 6,070 to 6,080,
T128c,T506b,T480on both sides,T502aandT502b, and thefrozen-name list growing by two rows.
Stacked, and the merge order
Base is
tests/t483-t486(#24), notmain, because the count is a measurement of ctrlrunmainandit moves twice:
#24 → ctrlrun#191 → this. #24 first matches
maintomainas they stand, so docsmainisnever briefly wrong between the two.
And one guard CI was not running
render_readiness.py's docstring calls--check"what CI runs". CI did not run it. That is thesentence one level up from the comment beside the audit step: a guard CI does not run is prose.
The test count is the one figure on the site that is a measurement rather than a claim, and
nothing in CI re-took it. The pytest check compares the embedded block against the stored
generated/readiness.json, so the page and the state file agreed with each other while both driftedaway from the library. Right now they are four apart: the site says 6,066, ctrlrun
maincollects 6,070. That is how today's count drifted through three PRs without anything going red.
It cannot flap between a paired kernel and docs merge, which is why it is safe to add mid-stack
rather than after. The count is a floor:
--checkfails when the suite has fewer tests thanthe page claims and passes when it has more, so a kernel PR that adds tests leaves docs
maingreenuntil its docs pair lands. Verified both ways against real checkouts, docs
mainagainst kernelmain:0 drifted; this branch against ctrlrun#191:0 drifted.test_ci_runs_the_three_checks_and_the_drift_checkreads the workflow, so the list and the jobcannot disagree.
Checked
All seven generators,
19 recipes, 0 drifted,83 pages, claimsre-pointed 0, unresolved 0. Thekernel worktree came back clean after the cookbook write, which is the check that would have
caught the SPDX-stripping defect the release pass found. Whole docs suite green against ctrlrun#191.
Not merging.