Regenerate for needs_approval's new signature, and readiness at 6,080 - #25
arpanghoshal wants to merge 2 commits into
Conversation
Pairs with ctrlrun#190, which adds `test_every_v0_10_name_the_spec_freezes_is_importable_with_the_parameter_it_names` and `test_the_three_rows_of_section_9_that_did_not_ship_still_have_not`. Stacked on `tests/t483-t486` (#24), not on `main`, because the count is cumulative: #24 carries 6,068 for ctrlrun#189 and this carries 6,070 for #190. Merged bottom-up they are each right in turn; merged out of order one of them is wrong.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ctrlrun#190 grew from recording three unshipped `SPEC-v0.10 §9` names to building two of them, so this is no longer a readiness bump. `needs_approval` now takes `task=` and `hop=`, which changes its API page: the signature and the paragraph saying what the parameters are for. `banner.mdx` moves with it because the two share a source line range. Readiness 6,070 to 6,080: T128c, T506b, T480 on both sides, T502a and T502b, and the two frozen-name tests. All seven generators, `19 recipes, 0 drifted`, `83 pages`, claims `re-pointed 0, unresolved 0`, and the kernel worktree came back clean after the cookbook write.
|
Closing rather than merging: superseded by #26. This branch was named The same content is in #26, on branch |
Pairs with ctrlrun#190. Same branch name on both sides, so CI here checks against that kernel
branch rather than against
main.This is no longer a readiness bump. ctrlrun#190 grew from recording three unshipped
SPEC-v0.10 §9names to building two of them, and one is a public API change.What changed
ctrlrun.adapter.needs_approvalnow takestask=andhop=:Its API page picks up the signature and the paragraph saying what they are for: without them the
predicate evaluated against the receiver's whole candidate set while
executeevaluates against thehop alone, so it answered "a human is needed" for a call
executethen refuses.banner.mdxmoveswith it because the two share a source line range.
Readiness 6,070 to 6,080 —
T128c,T506b,T480on both sides,T502a,T502b, and the twofrozen-name tests.
Stacked, and why
Base is
tests/t483-t486(#24), notmain. The count is cumulative:Merge order: #24 → ctrlrun#190 → this. Out of order, one of them is wrong, which is exactly what
this check is for.
Checked
All seven generators,
19 recipes, 0 drifted,83 pages, claimsre-pointed 0, unresolved 0. Thekernel worktree came back clean after the cookbook write, which is the check that would have
caught the SPDX-stripping defect the release pass found. Whole docs suite green.
Not merging.