Skip to content

Regenerate for needs_approval's new signature, and readiness at 6,080 - #25

Closed
arpanghoshal wants to merge 2 commits into
tests/t483-t486from
spec/section-9-reconciled
Closed

arpanghoshal wants to merge 2 commits into
tests/t483-t486from
spec/section-9-reconciled

Conversation

@arpanghoshal

@arpanghoshal arpanghoshal commented Sep 13, 2026

Copy link
Copy Markdown
Member

Pairs with ctrlrun#190. Same branch name on both sides, so CI here checks against that kernel
branch rather than against main.

This is no longer a readiness bump. ctrlrun#190 grew from recording three unshipped
SPEC-v0.10 §9 names to building two of them, and one is a public API change.

What changed

ctrlrun.adapter.needs_approval now takes task= and hop=:

-def needs_approval(control, action, arguments, *, resource=None) -> bool
+def needs_approval(control, action, arguments, *, resource=None, task=None, hop=None) -> bool

Its API page picks up the signature and the paragraph saying what they are for: without them the
predicate evaluated against the receiver's whole candidate set while execute evaluates against the
hop alone, so it answered "a human is needed" for a call execute then refuses. banner.mdx moves
with it because the two share a source line range.

Readiness 6,070 to 6,080T128c, T506b, T480 on both sides, T502a, T502b, and the two
frozen-name tests.

Stacked, and why

Base is tests/t483-t486 (#24), not main. The count is cumulative:

PR kernel pair count
#24 ctrlrun#189 — merged 6,068
this ctrlrun#190 6,080

Merge order: #24 → ctrlrun#190 → this. Out of order, one of them is wrong, which is exactly what
this check is for.

Checked

All seven generators, 19 recipes, 0 drifted, 83 pages, claims re-pointed 0, unresolved 0. The
kernel worktree came back clean after the cookbook write, which is the check that would have
caught the SPDX-stripping defect the release pass found. Whole docs suite green.

Not merging.

Pairs with ctrlrun#190, which adds `test_every_v0_10_name_the_spec_freezes_is_importable_with_the_parameter_it_names`
and `test_the_three_rows_of_section_9_that_did_not_ship_still_have_not`.

Stacked on `tests/t483-t486` (#24), not on `main`, because the count is cumulative: #24 carries
6,068 for ctrlrun#189 and this carries 6,070 for #190. Merged bottom-up they are each right in
turn; merged out of order one of them is wrong.
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 790856eb-8082-44bf-85ed-b53225fcde0d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

ctrlrun#190 grew from recording three unshipped `SPEC-v0.10 §9` names to building two of them, so
this is no longer a readiness bump.

`needs_approval` now takes `task=` and `hop=`, which changes its API page: the signature and the
paragraph saying what the parameters are for. `banner.mdx` moves with it because the two share a
source line range.

Readiness 6,070 to 6,080: T128c, T506b, T480 on both sides, T502a and T502b, and the two
frozen-name tests.

All seven generators, `19 recipes, 0 drifted`, `83 pages`, claims `re-pointed 0, unresolved 0`, and
the kernel worktree came back clean after the cookbook write.
@arpanghoshal arpanghoshal changed the title Readiness at 6,070: the two frozen-name tests Regenerate for needs_approval's new signature, and readiness at 6,080 Sep 13, 2026
@arpanghoshal

Copy link
Copy Markdown
Member Author

Closing rather than merging: superseded by #26.

This branch was named spec/section-9-reconciled to pair with ctrlrun#190. That PR merged only the first commit of its branch, so the kernel branch this one is named for no longer exists — the cross-repo check here would fall back to main and fail on a count ten ahead of it.

The same content is in #26, on branch fix/section-9-build-and-close, paired with ctrlrun#191, which carries the stranded commit.

Merge order: #24 → ctrlrun#191 → #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant