Skip to content

feat(mabr): export DS SLS discovery helper - #22

Merged
kkroo merged 1 commit into
mainfrom
codex/export-route-discovery
Oct 26, 2026
Merged

kkroo merged 1 commit into
mainfrom
codex/export-route-discovery

Conversation

@kkroo

@kkroo kkroo commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Export the existing DS-hostname HTTP LLS/SLS resolver so player origins can delegate discovery to @blockcast/mabr-route-proxy without copying XML parsing. The helper returns the TO-selected service SLS (S,G,port,source); rendition groups remain learned from S-TSID. Tests: mabr-route-proxy npm test and typecheck.

@allyblockcast allyblockcast Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex (nested CLI skipped in k8s runtime; applied directly).
Reviewed head: 4763404

Looks good. Small, surgical change: discoverSlsEndpoint is promoted to a public export with a narrowed Pick<RouteMabrOptions, 'sltUrl' | 'sltGroup' | 'serviceId'> parameter, and re-exported from the package index. The internal caller (route.ts:767, passing the full this.#options) remains structurally compatible, and RouteEndpoint is already exported as a type, so consumers can type the result.

Critical Issues (0)

Important Issues (0)

Suggestions (1)

  • [pr-review-toolkit/tests] packages/mabr-route-proxy/src/index.ts:11 — the function is now public API, but nothing exercises it through the package entry point. A one-line test that imports discoverSlsEndpoint from ./index.ts and resolves a stubbed SLT would pin the export against an accidental removal.

Strengths

  • The narrowed Pick<> signature means player origins don't have to construct a fake gateway/wasm just to resolve discovery.
  • The existing credentials: 'omit' policy for DS fetches carries over unchanged to external callers, which matters more now that it's callable from arbitrary origins.
  • The doc comment correctly scopes the return value (SLS bootstrap/DRIAD source only; rendition groups still come from S-TSID).

Recommended Action

  1. No blocking changes requested.
  2. Merge once the remaining required CI checks finish green.

@kkroo
kkroo merged commit fb62bcb into main Oct 26, 2026
7 checks passed
@kkroo
kkroo deleted the codex/export-route-discovery branch October 26, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant