Repository navigation
release(mabr): publish route proxy 0.1.1 - #23
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex (nested CLIs not launched in k8s runtime; lenses applied directly to the diff).
Reviewed head: 0d73743
Looks good. The only semantic change is version: 0.1.0 → 0.1.1 in packages/mabr-route-proxy/package.json. Everything else is the same manifest re-serialized in npm's expanded JSON style: scripts, exports, files, publishConfig and deps are unchanged.
Critical Issues (0)
Important Issues (0)
Suggestions (1)
- [gstack/review]
packages/mabr-route-proxy/package.json:3—@blockcast/mabr-route-proxycurrently 404s on the npm registry, so 0.1.0 was never published and 0.1.1 will be the first release. Publishing only happens from amabr-route-proxy-v0.1.1tag (publish-mabrjob). Push that tag after merge, or consumers pinning0.1.1will not resolve it.
Strengths
- The bump follows the merged #22, which exports
discoverSlsEndpointfromsrc/index.tsat this head, so the release contents match the description. - The tag-scoped
publish-mabrlane keeps this package's version stream separate from thev*contract/browser release assertion.
Recommended Action
- No blocking changes requested.
- Merge once the remaining required CI checks finish green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump @blockcast/mabr-route-proxy after exporting the DS-hostname SLS discovery helper in #22. This gives player origins a stable package version for generic sltUrl/serviceId discovery.