Repository navigation
Correct reflected HTML template and foreign-content contexts - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The reflected-tag probe counted inert HTML template contents as active and treated SVG/MathML elements such as
titleas HTML raw text. The reduced parser now tracks namespaces and template boundaries, including HTML integration points, foreign-content breakouts, self-closing foreign elements, CDATA and escaped script states.Tag context changes occur only after a complete tag. Attribute values are parsed separately from names, duplicate encoding attributes use their first value, and apparent closing tags inside template comments or raw text remain inert.
The roadmap, changelog and build checklist record the fixes and retain a partial grade. A marker is evidence of element injection, not proof that arbitrary script executes. Frameset insertion modes remain a reproduced false positive; full browser tree construction and XML, stored and DOM XSS are separate work.
Validation
Dependency #28 is merged. This PR contains the HTML-context correction and its tests/documentation.
Owner: Bikebrainz.
All eight CI jobs passed on c2539ce: https://github.com/Bikebrainz/Nullock/actions/runs/36658036595