Repository navigation
Keep native Repeater sends responsive and expose Stop - #30
Open
Bikebrainz wants to merge 3 commits into
Open
Bikebrainz wants to merge 3 commits into
Bikebrainz wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The native Repeater window called the blocking send method even though the browser, API and CLI already used the background worker. Native Send now calls
sendAsync, displays Send/Stop progress and disables Send/Clear while work is active.The handler copies the visible target fields before starting; Rectangle buttons do not necessarily move focus out of an edited field. Blank hosts and ports outside 1–65535 disable Send. The cancellation property is exposed to QML so Stop shows its pending state.
Stop still waits for the current response or transport timeout and skips subsequent redirects. Immediate socket cancellation and simultaneous requests remain separate work. The website roadmap, changelog, docs and build checklist reflect that distinction.
Validation
Dependencies #28 and #29 are merged. This PR contains the native Send/Stop controls, their QML regression and matching documentation.
Owner: Bikebrainz.