implement s7 classes#87
Merged
MaartenMarsman merged 1 commit intoBayesian-Graphical-Modelling-Lab:mainfrom Mar 27, 2026
Merged
Conversation
Collaborator
Author
|
The R devel check fails because some other R package could not be installed. |
17 tasks
MaartenMarsman
approved these changes
Mar 27, 2026
822a280
into
Bayesian-Graphical-Modelling-Lab:main
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Bayesian-Graphical-Modelling-Lab/issues/issues/79
Description
Provide a concise summary of the changes.
Problem / Motivation
This fixes the fragile S3 methods with cache for lazy computations, those are now implemented like so:
So there is a proper
gettermethod that does the computation.Note that we have a lot of
class_any. This could be a more constrained type, but for now this is fine I think.Key difference for users
However, if users do/ did
extract_main_effectsthen nothing changed.Type of Change
Documentation and Release Notes
man/*.Rdfiles if roxygen comments changed_pkgdown.ymlif adding a new exported functionNEWS.mdentry if the change affects usersTesting and Validation
Describe the checks you ran and the main results.
tests/testthat/when neededresult =captures that must be reverted toresult <-lintr::lint_package()roxygen2::roxygenise()if roxygen comments changedrcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"))for non-trivial changes