add callback function to show progress in JASP#88
Open
vandenman wants to merge 1 commit intoBayesian-Graphical-Modelling-Lab:mainfrom
Open
add callback function to show progress in JASP#88vandenman wants to merge 1 commit intoBayesian-Graphical-Modelling-Lab:mainfrom
vandenman wants to merge 1 commit intoBayesian-Graphical-Modelling-Lab:mainfrom
Conversation
MaartenMarsman
requested changes
Mar 27, 2026
Collaborator
MaartenMarsman
left a comment
There was a problem hiding this comment.
R-CMD-check fails on all platforms with one test failure:
test-validate-sampler.R:398 — "return list has all 11 expected elements" now fails because validate_sampler() returns 12 elements (the new progress_callback). Fix:
test_that("return list has all 12 expected elements", {
res = vs()
expected_names = c(
"update_method", "target_accept", "iter", "warmup",
"hmc_num_leapfrogs", "nuts_max_depth", "learn_mass_matrix",
"chains", "cores", "seed", "progress_type", "progress_callback"
)
expect_named(res, expected_names)
})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Bayesian-Graphical-Modelling-Lab/issues/issues/69
Adds a callback function to forward progress to JASP.
IMPORTANT! This PR is incompatible with #87. It doesn't matter which is merged first, but afterward the remaining PR must be updated again.
To try it out, run the following code. It runs bgm on the Wenchuan data with the following progress bars:
utils::txtProgressBarcli::cli_progress_barType of Change
Documentation and Release Notes
man/*.Rdfiles if roxygen comments changed_pkgdown.ymlif adding a new exported functionNEWS.mdentry if the change affects usersTesting and Validation
Describe the checks you ran and the main results.
tests/testthat/when neededresult =captures that must be reverted toresult <-lintr::lint_package()roxygen2::roxygenise()if roxygen comments changedrcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"))for non-trivial changes