Repository navigation
Keep paths outside ccdeck out of error reports - #1935
Merged
Merged
Conversation
The error scrub only swapped the home folder for ~, so everything after it left: a project's folder under ~/.claude/projects, a path under /mnt or another drive, a file:// frame. Every path outside ccdeck's own package now leaves as <path> (with ~ and ~/.claude or ~/.codex kept in front), a project folder in Claude Code's encoding as <project>, and a frame of ccdeck's own keeps its place in the package (ccdeck/src/server/tail.mjs:42:7) however it was installed. The page's scrub of the crash text it seeds feedback with follows the same patterns.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
~, so the rest of a path left with the error: a project's folder under~/.claude/projects/, a path under/mntor on another drive or share, afile://frame. Now every such path is sent as<path>(with~and~/.claudeor~/.codexkept in front when it had them), and a project folder in Claude Code's encoding (-home-alice-acme,C--Users-Bob-acme) as<project>.ccdeck/src/server/tail.mjs:42:7— whether the deck runs from npx, a global install, a source checkout or the desktop app, so a stack still says where the bug is and reads the same on every machine. A dependency npx put beside the package keepsnode_modules/<pkg>/….Verification
npm run typecheckclean.--maxWorkers=3 --minWorkers=1): 889 files, 11646 tests passed, exit 0.src/web/__tests__/error-report-paths.test.ts: an ENOENT on~/.claude/projects/-home-alice-Desktop-acme-secret/…,/mnt/work/acme,D:\clients\acme, a UNC share,file://frames, quoted and framed paths with spaces, bare encoded project folders; the deck's own frames on npx, checkout, macOS app and Windows app roots; addresses,node:internalframes and plain words left alone; and one end-to-endreportErrorwith a stubbed fetch. Before the fix, 38 of its cases failed with the path or project left in the text.reports-1853.test.tsandvisible-feedback-1853.test.tsrepointed from "the tail after ~ stays" to the new shape.