Windows: drop the space-in-path staging; macOS: enable Accelerate ILP64 - #174
Draft
mmelnich wants to merge 1 commit into
Draft
Windows: drop the space-in-path staging; macOS: enable Accelerate ILP64#174mmelnich wants to merge 1 commit into
mmelnich wants to merge 1 commit into
Conversation
Both halves ride on upstream fixes now in flight, pinned for the moment to the upstream PR heads (fetchable by SHA) and to be flipped to the merge commits when they land: - blaspp advances past icl-utk-edu/blaspp#137: BLAS_LIBRARIES entries are no longer split on spaces, so Copy-LibrariesToSpaceFreePath and its two call sites go away (closes #158). The staging was the reason a discovered oneMKL at Intel's default spaced location worked in CI. - lapackpp advances past icl-utk-edu/lapackpp#90 (fixes lapackpp#89): LAPACK++ now compiles against Accelerate ILP64, so the installer's LP64 constraint and the explicit-ilp64 refusal are lifted; Accelerate rejoins the standard prefer-ILP64 width policy (closes #173). The install-macos assertion flips accelerate,LP64 -> accelerate,ILP64, and the INSTALL_SCRIPT.md width tables update to match.
Draft
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last two items gated on upstream, combined into one pin-advance PR. Draft until both upstream PRs merge; everything else is final.
Closes #158. Closes #173.
Changes
c3ef942):BLAS_LIBRARIESentries are no longer split on spaces.f891adc, fixes lapackpp#89): LAPACK++ compiles against Accelerate ILP64.Copy-LibrariesToSpaceFreePathand its two call sites deleted from the Windows provisioner — a discovered oneMKL at Intel's default spaced location now reaches BLAS++ unstaged. (The doc notes Remove the Windows space-in-path workaround once blaspp#137 lands #158 listed were already removed during Windows installation overhaul #156.)ilp64refusal are lifted; Accelerate rejoins the standard prefer-ILP64 width policy (auto→ ILP64 on macOS ≥ 13.3, LP64 fallback with a warning on older macOS). The install-macos assertion flipsaccelerate, LP64→accelerate, ILP64; INSTALL_SCRIPT.md §6.1/§6.2 updated.Ready when (the do-this-immediately list)
BLASPP_REFininstallers/install.shand$blasppRefin.github/actions/setup-randlapack-deps-windows/setup.ps1with the merge commit, delete the TEMPORARY-PIN commentsLAPACKPP_REF/$lapackppRefRandBLAS mirror of the #137 half: the draft PR on
drop-space-workaround-and-comment-fix.