Windows: adopt the blaspp space-split fix; correct the set -e comment - #199
Draft
mmelnich wants to merge 2 commits into
Draft
Windows: adopt the blaspp space-split fix; correct the set -e comment#199mmelnich wants to merge 2 commits into
mmelnich wants to merge 2 commits into
Conversation
The comment claimed a top-level '[[ test ]] && cmd' with a false test exits under set -e. It does not: the failing command is exempt as part of a && list. The construct only bites as the last statement of a function, where the test's failure becomes the function's return status. The if-blocks stay; only the explanation changes. Closes #195.
Advance the BLAS++ pin past icl-utk-edu/blaspp#137 (temporarily its PR head; final merge commit when it lands) and the LAPACK++ pin past icl-utk-edu/lapackpp#90 for parity. RandBLAS's provisioner never staged libraries into a space-free path -- its vcpkg download lands space-free by construction -- so issue #188's substance here is the pin advance plus proof: the Windows lanes now deliberately hand BLAS++ the oneMKL import libraries from a directory containing a space, emulating Intel's default install location. Closes #188.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small items combined, one of them gated on upstream. Draft until icl-utk-edu/blaspp#137 merges; everything else is final.
Closes #188. Closes #195.
Changes
c3ef942so CI can prove the result today; flipped to the merge commit when it lands). RandBLAS's provisioner never carried explicit space-free staging — its vcpkg download lands space-free by construction — so the issue's substance here is the pin plus a standing proof: the Windows lanes now deliberately hand BLAS++ the oneMKL import libraries from a directory containing a space (path with spaces), emulating Intel's default install location. The LAPACK++ pin advances past icl-utk-edu/lapackpp#90 for parity (it only matters for--examples).set -ecomment above the examples-command assembly is corrected per the issue's suggested wording — a top-level[[ test ]] && cmdwith a false test does not exit; the construct only bites as the last statement of a function.Ready when
BLASPP_REFininstallers/install.shand$BlasppRefin.github/actions/setup-randblas-deps-windows/setup.ps1with the merge commit, drop the TEMPORARY-PIN commentsRandLAPACK mirror (its staging removal + Accelerate ILP64): BallisticLA/RandLAPACK#174.