Wire deployed ACA qualification CI - #197
Draft
Laveesh Rohra (larohra) wants to merge 4 commits into
Draft
Conversation
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-ci
branch
from
September 2, 2026 23:04
7c4f1ee to
7b9d5a1
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-ci
branch
from
September 2, 2026 23:39
7b9d5a1 to
ea3f6aa
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-ci
branch
from
September 3, 2026 15:56
ea3f6aa to
4aeebaa
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-ci
branch
from
September 3, 2026 16:50
4aeebaa to
67d75e0
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-ci
branch
4 times, most recently
from
September 3, 2026 19:54
8cfb4af to
128c2fc
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Qualification must stop after failed provenance verification, and the operational guide must list all required app settings.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds nonblocking deployed ACA qualification to the E2E pipeline for trusted manual runs and main-branch CI.
Changes:
- Adds parallel Python 3.13/3.14 deployment and qualification jobs.
- Documents pipeline configuration, prerequisites, and triage.
- Adds wiring contract tests and updates FRD/live-test documentation.
File summaries
| File | Description |
|---|---|
eng/ci/e2e-tests.yml |
Adds the qualification stage and execution condition. |
eng/templates/official/jobs/aca-qualify.yml |
Defines deployment and qualification matrix jobs. |
eng/ci/docs/aca-qualification.md |
Adds the operational guide. |
tests/test_aca_qualification_pipeline.py |
Tests pipeline wiring and policy. |
tests/live/README.md |
Documents automated qualification coverage. |
docs/frds/0008-aca-sandbox-session-runtime.md |
Records the finalized CI policy. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Base automatically changed from
larohra/aca-qualification-assets
to
feature/aca-sandboxes
September 4, 2026 18:54
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 341c0dc5-0199-4e8d-9105-ce96efbe0ac2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 341c0dc5-0199-4e8d-9105-ce96efbe0ac2
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-ci
branch
from
September 4, 2026 19:01
128c2fc to
d8e7eb4
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two existing operational guides still incorrectly state that deployed qualification has no pipeline wiring.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 341c0dc5-0199-4e8d-9105-ce96efbe0ac2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack layer 4/5
Parent: #196
Summary
AcaQualificationstage afterBuildin the E2E pipeline, with independent Python 3.13 and 3.14 matrix jobs.IndividualCI/BatchedCIonrefs/heads/main; trusted operators may manually queue any branch. PR and Schedule reasons remain excluded.Manual-run trust boundary
A manual run executes branch-controlled YAML and scripts under the deployment service connection. This is intentionally authorized through restricted pipeline queue permissions for trusted operators so feature branches can be validated before merge. Protected-branch or environment checks are not added because they would defeat that approved workflow.
Validation
python -m pytest tests/test_aca_qualification_pipeline.py -q— 65 passedpython -m ruff check src testspython -m mypy src— 98 source filesgit diff --checkmaxParallel: 2, no variable group, and no sweepThis replaces the CI-trigger, deployment-identity, Python-matrix, and basic-variable-policy portion of draft #169 without modifying or closing it.