Add ACA qualification leak sweep - #198
Draft
Laveesh Rohra (larohra) wants to merge 3 commits into
Draft
Conversation
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 2, 2026 23:08
7fcf59b to
8b3efde
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 2, 2026 23:48
8b3efde to
617a8ab
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 3, 2026 15:56
617a8ab to
84c058d
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 3, 2026 16:55
84c058d to
6124f03
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 3, 2026 17:36
6124f03 to
87feca2
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 3, 2026 18:34
87feca2 to
3d6c4d5
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 3, 2026 18:53
3d6c4d5 to
5f30a32
Compare
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 3, 2026 19:59
5f30a32 to
bb296b6
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Snapshot leaks remain unhandled, and concurrent sandbox deletion can be incorrectly reported as a failure.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a nonblocking pre-run leak sweep to ACA qualification CI.
Changes:
- Runs
AcaSweepalongsideBuild. - Deletes resources older than six hours with durable warnings.
- Adds tests and operational documentation.
File summaries
| File | Description |
|---|---|
tests/test_aca_qualification_pipeline.py |
Tests sweep behavior and pipeline wiring. |
eng/templates/official/jobs/aca-sweep.yml |
Defines the sweep job. |
eng/scripts/README.md |
Documents the sweep command. |
eng/scripts/aca_qualification_pipeline.py |
Implements cleanup and reporting. Requires handling already-absent sandboxes as successful and sweeping orphaned snapshots. |
eng/ci/e2e-tests.yml |
Wires sweep and qualification dependencies. |
eng/ci/docs/aca-qualification.md |
Documents operations and troubleshooting. |
docs/frds/0008-aca-sandbox-session-runtime.md |
Records the finalized design decision. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 4, 2026 19:06
bb296b6 to
bf5313e
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc895b41-586d-4824-97b1-6761d99a35de
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc895b41-586d-4824-97b1-6761d99a35de
Laveesh Rohra (larohra)
force-pushed
the
larohra/aca-qualification-sweep
branch
from
September 8, 2026 23:20
df6ec3b to
70113a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Stack layer 5/5, targeting parent draft PR #197 (
larohra/aca-qualification-ci). This replaces the leak-sweep and cleanup-observability portion of draft PR #169 without modifying or closing #169 or any prior replacement-layer PR.Change
AcaSweepstage alongsideBuild;AcaQualificationwaits for both while gating only on the Build result, so sweep infrastructure failure cannot suppress qualification.exclusive-ci-qualificationacknowledgment before unfiltered inspection/deletion. This asserts an external infrastructure prerequisite; the ACA data-plane API cannot prove group ownership or exclusivity.incompleteanddelete_failuresand cannot present failed inspection as a clean group.Validation
79 passed—tests/test_aca_qualification_pipeline.pyruff check src testsruff check eng/scripts/aca_qualification_pipeline.pymypy src— 98 source filesgit diff --checkAcaSweep, Build+AcaSweep dependency, Build-only qualification gate, Python 3.13/3.14maxParallel: 2, one explicit acknowledgment, and no ACA variable-group reference.