Skip to content

feat: broker related entities - #70

Merged
keeva-c merged 4 commits into
mainfrom
broker-related-entities
Oct 1, 2026
Merged

keeva-c merged 4 commits into
mainfrom
broker-related-entities

Conversation

@keeva-c

@keeva-c keeva-c commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

📌 Summary

Adding project_id and sample_id fields into canopy broker endpoint responses so that the data-broker can submit experiments using the relevant parent project and sample accessions.


🔄 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Refactor (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • ⚙️ CI / build / tooling change

🧩 Key Changes

  • adding project_id and sample_id fields in the broker/claims endpoint responses
  • writing functions for database lookups to find the project id and sample id for an experiment id
  • replacing the ERS accession with the SAMEA accession as the 'prerequisite' sample accession in the broker endpoint responses

✅ Checklist

  • Tests are passing locally / in CI
  • New tests have been added for new or changed functionality
  • Self-review completed
  • Documentation updated (if needed)
  • No sensitive data or secrets included

🔍 Review Notes


📎 Related Issues / Tickets


@TomHarrop TomHarrop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! It's only the broker endpoints so should be safe to merge and try it?

@keeva-c
keeva-c merged commit 8446e91 into main Oct 1, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants