Repository navigation
feat: broker related entities - #70
Merged
Merged
Conversation
TomHarrop
approved these changes
Oct 1, 2026
TomHarrop
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me! It's only the broker endpoints so should be safe to merge and try it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Adding
project_idandsample_idfields into canopy broker endpoint responses so that thedata-brokercan submit experiments using the relevant parent project and sample accessions.🔄 Type of Change
🧩 Key Changes
project_idandsample_idfields in thebroker/claimsendpoint responsesERSaccession with theSAMEAaccession as the 'prerequisite' sample accession in the broker endpoint responses✅ Checklist
🔍 Review Notes
📎 Related Issues / Tickets