[feat] Support changing master_server port for MooncakeStore#62
Merged
0oshowero0 merged 2 commits intoAscend:mainfrom Mar 28, 2026
Merged
[feat] Support changing master_server port for MooncakeStore#620oshowero0 merged 2 commits intoAscend:mainfrom
0oshowero0 merged 2 commits intoAscend:mainfrom
Conversation
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for configuring the MooncakeStore mooncake_master RPC port from backend.MooncakeStore.master_server_address during auto-init, so the spawned master process can match the client’s configured master endpoint.
Changes:
- Parse/validate
backend.MooncakeStore.metadata_serverinto host/port variables (renamed for clarity). - Parse/validate
backend.MooncakeStore.master_server_addressand extract its port. - Pass the extracted port to
mooncake_mastervia a new--rpc_port=...CLI argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
vermouth1992
pushed a commit
to vermouth1992/TransferQueue
that referenced
this pull request
Mar 28, 2026
Allow using non-default master_service port to start the master_service when using auto_init feature for MooncakeStore backend --------- Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> Signed-off-by: Chi Zhang <czhangseu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using non-default master_service port to start the master_service when using auto_init feature for MooncakeStore backend