Skip to content

feat: stop_radar cleanup and match_recorder node check - #21

Merged
Yukikaze2233 merged 1 commit into
mainfrom
develop
Aug 3, 2026
Merged

Yukikaze2233 merged 1 commit into
mainfrom
develop

Conversation

@Yukikaze2233

@Yukikaze2233 Yukikaze2233 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • stop_radar also kills replay/recorder/static TF leftover processes (SHM holder blocked hikcamera startup)
  • radar startup detail panel now checks match_recorder node

Verification

  • cargo test passes

Summary by CodeRabbit

  • 改进
    • 雷达节点状态检查现已纳入 match_recorder,可更完整地监控容器内 ROS2 节点。
    • 停止雷达进程时,将同步清理回放、位置记录和静态变换发布相关进程,提升停止操作的完整性。

…ecorder to node check

- stop_radar: also pkill mp4_replay, location_recorder, static_transform_publisher
  (leftover SHM holder prevented hikcamera driver startup)
- radar node status panel now includes match_recorder
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 522f3939-f3e1-4847-b6e7-86a3d1c650c0

📥 Commits

Reviewing files that changed from the base of the PR and between 9e4be30 and b9595b5.

📒 Files selected for processing (2)
  • src/app/radar_workspace.rs
  • src/services/script_runner.rs

📝 Walkthrough

Walkthrough

雷达节点检查列表新增 match_recorderstop_radar 现在会清理 mp4_replaylocation_recorderstatic_transform_publisher 进程。

Changes

雷达生命周期管理

Layer / File(s) Summary
节点检查与停止清理
src/app/radar_workspace.rs, src/services/script_runner.rs
节点状态检查新增 match_recorderstop_radar 新增三个容器进程的终止命令,并保留末尾的 true

Estimated code review effort: 2 (简单) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了停止雷达时的进程清理和新增的match_recorder节点检查,内容清晰且简洁。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Yukikaze2233
Yukikaze2233 merged commit 4bdc6da into main Aug 3, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant