Skip to content

Audit native license provenance and complete known notices - #100

Merged
perNyfelt merged 3 commits into
mainfrom
audit-native-licenses
Nov 16, 2026
Merged

perNyfelt merged 3 commits into
mainfrom
audit-native-licenses

Conversation

@perNyfelt

@perNyfelt perNyfelt commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The native payload's existing notices omitted several compiled-in adaptations. This review adds NumPy/opt_einsum, supervised-lda, SIMD math, PyTorch/TensorFlow and GPU/PRNG reference notices, and expands the inventory to 26 entries. The explicit native release check now verifies the legal text digests in main, sources and Javadoc JARs and scans main-JAR non-payload entries plus companion entries for forbidden home/checkout paths. The five native payload files retain their dedicated binary/path verifier and pinned MLX exception.

The dated audit records scope, build/source evidence, exclusions, artifact hashes and reproduction commands. Small reports and logs are committed outside build/. The source checker validates pinned upstream content and extracted notices, including the wheel's actual metal-cpp license.

Review corrections:

  • Explicit UTF-8 notice decoding, validated excerpt bounds/fragments and matching within each component's own notice section.
  • URL-plus-digest cache identity, atomic installation and read-only cache hits; distinct equal-content URLs are fetched independently.
  • A distinctive literal notice separator preserves ordinary equals-sign rules inside upstream licenses.
  • Main-JAR manifests, META-INF and other non-payload entries receive the forbidden-prefix scan, including unexpected files under the native directory.
  • Contextual errors for malformed/empty Stack Exchange replies and an independent requirement for all four legal files in every artifact.
  • Regression coverage for network and JSON paths, cache integrity/atomicity, locale, section binding, inventory omissions and the companion-JAR CLI/path checks.

Two provenance findings remain release blockers: the Stack Overflow-derived Juffa erf/erfinv implementations, and the Cephes permission chain. Source/packaging consistency passes, but --require-clear correctly exits 1 and the readiness gate stays unchecked. Native payload bytes and upstream pins are unchanged; no candidate cut or publication occurred.

Latest validation:

  • All 74 release selftests passed locally (59.161 seconds), including 17 focused license tests.
  • Native check, verifyNativeReleasePayload and POM generation passed (15 tasks: 6 executed, 9 up-to-date).
  • The prior review's real fresh-cache audit ran with LC_ALL=en_US.ISO8859-1, PYTHONUTF8=0 and PYTHONCOERCECLOCALE=0; Python measured preferred encoding ISO8859-1. It verified 26 notice entries, 34 additional source records, 57 distinct URL/digest pairs in 57 independent cache entries and all three JARs. The expected unresolved-findings exit 1 was retained.
  • The latest follow-up rehashed that URL-bound cache and verified the updated notice sections and three rebuilt JARs under the same ISO-8859-1 environment. Main-JAR metadata/path and distinctive-separator regressions pass; --require-clear still exits 1 for the legal findings. Followup-prefixed evidence records this warm-cache check separately from the earlier cold run.
  • All evidence/verifier/notice digests match; git diff --check passes.

Review-prefixed evidence supersedes the initial cache/network verification. The unprefixed logs remain explicitly historical: the original digest-only cache fetched 56 of 57 distinct URL/digest pairs. No earlier CI run is offered as evidence for these review changes.

Audit: req/phase8-4-native-license-audit.md and .json. This PR records findings and fixes confirmed omissions; it does not close the license release gate.

@perNyfelt
perNyfelt merged commit ee807c9 into main Nov 16, 2026
3 checks passed
@perNyfelt
perNyfelt deleted the audit-native-licenses branch November 16, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant