Repository navigation
Audit native license provenance and complete known notices - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native payload's existing notices omitted several compiled-in adaptations. This review adds NumPy/opt_einsum, supervised-lda, SIMD math, PyTorch/TensorFlow and GPU/PRNG reference notices, and expands the inventory to 26 entries. The explicit native release check now verifies the legal text digests in main, sources and Javadoc JARs and scans main-JAR non-payload entries plus companion entries for forbidden home/checkout paths. The five native payload files retain their dedicated binary/path verifier and pinned MLX exception.
The dated audit records scope, build/source evidence, exclusions, artifact hashes and reproduction commands. Small reports and logs are committed outside build/. The source checker validates pinned upstream content and extracted notices, including the wheel's actual metal-cpp license.
Review corrections:
Two provenance findings remain release blockers: the Stack Overflow-derived Juffa erf/erfinv implementations, and the Cephes permission chain. Source/packaging consistency passes, but --require-clear correctly exits 1 and the readiness gate stays unchecked. Native payload bytes and upstream pins are unchanged; no candidate cut or publication occurred.
Latest validation:
Review-prefixed evidence supersedes the initial cache/network verification. The unprefixed logs remain explicitly historical: the original digest-only cache fetched 56 of 57 distinct URL/digest pairs. No earlier CI run is offered as evidence for these review changes.
Audit: req/phase8-4-native-license-audit.md and .json. This PR records findings and fixes confirmed omissions; it does not close the license release gate.