Repository navigation
Prepare owner review for native license resolution - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native release remains blocked on Juffa erf/erfinv and Cephes provenance. This review investigates the primary sources, records the owner's request (ml-explore/mlx#4902) and makes the research evidence reproducible. Both findings remain open pending applicable clarification and owner/legal review.
The explicitly BSD-licensed NVIDIA forum samples differ from the shipped MLX functions. Retained samples preserve their complete licenses, with raw/normalized hashes and bounded floating-literal comparisons against pinned MLX/Stack Overflow versions. CPU erf is explicitly outside the Juffa comparison: its PyTorch approximation is already covered by the PyTorch notice.
The committed compare_literals.py recipe reproduces seven function records, five comparison results and both original comment-list hashes. research.json records its digest, the flat ownerUserId record shape, raw HTML bodies, API record order and exact sorted/compact ensure_ascii=True JSON serialization without a trailing newline.
Recipe limits and failure behavior are explicit:
Latest validation:
The review also examines original Cephes correspondence, MLX file history and official CC terms, and describes evidence needed for a grant, reviewed compliance route or separately reviewed implementation change. These lexical checks do not establish semantic equivalence or license scope. No additional grant or legal clearance is claimed.
No native code/pin/notice change, candidate cut or publication occurred. PR #100's native artifact/Gradle evidence remains historical; native implementation and legal findings are unchanged. The assistant posted no upstream issue or comment; the retained draft is historical and the owner submitted adapted wording.
Review packet: req/phase8-4-native-license-resolution.md.
Recipe and evidence: req/plans/evidence/native-license-resolution-2026-11-16/.