Skip to content

Prepare owner review for native license resolution - #101

Merged
perNyfelt merged 7 commits into
mainfrom
investigate-native-license-resolution
Nov 16, 2026
Merged

perNyfelt merged 7 commits into
mainfrom
investigate-native-license-resolution

Conversation

@perNyfelt

@perNyfelt perNyfelt commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The native release remains blocked on Juffa erf/erfinv and Cephes provenance. This review investigates the primary sources, records the owner's request (ml-explore/mlx#4902) and makes the research evidence reproducible. Both findings remain open pending applicable clarification and owner/legal review.

The explicitly BSD-licensed NVIDIA forum samples differ from the shipped MLX functions. Retained samples preserve their complete licenses, with raw/normalized hashes and bounded floating-literal comparisons against pinned MLX/Stack Overflow versions. CPU erf is explicitly outside the Juffa comparison: its PyTorch approximation is already covered by the PyTorch notice.

The committed compare_literals.py recipe reproduces seven function records, five comparison results and both original comment-list hashes. research.json records its digest, the flat ownerUserId record shape, raw HTML bodies, API record order and exact sorted/compact ensure_ascii=True JSON serialization without a trailing newline.

Recipe limits and failure behavior are explicit:

  • Extraction begins at the function name and ends at its balanced closing brace. Signs belong to literals only when directly attached.
  • The regex requires a decimal point, excluding exponent-only forms such as 1e-5f as well as integer/hexadecimal literals. None occurs in the seven recorded function inputs; numerical results are unchanged.
  • All research source rows are validated as objects with string IDs before use, including null/non-string IDs. Tested malformed evidence cases produce license comparison diagnostics without tracebacks.
  • read_source rejects non-string URLs before encoding, cache or network access. Both comment url:123 and MLX comparison source:123 were verified through the real CLI with recorded cached inputs: prefixed errors, no traceback or output report.
  • HTTPException is caught on the fetch path. A fault-injection test raises IncompleteRead from response.read(), verifying the prefixed exit and no partial cache/report; no live truncated transfer is claimed.
  • The current recorded offline command exactly matches the executed command and omits --fetch-missing.
  • The test docstring and review document identify the live selftest dependency on the dated recipe. Moving/archiving it requires coordinated path/evidence updates.

Latest validation:

  • All 82 release selftests passed locally (50.286 seconds), including eight focused recipe tests and real CLI malformed-evidence cases.
  • The original fresh-download reproduction matched both comment hashes; current offline replay preserves the recorded result byte for byte: seven records, five checks and hashes for 16/6 comments.
  • Independently checked the seven hashed function inputs for exponent-only literals: none found.
  • Retained evidence, verifier/test digests and local documentation links verified; git diff --check passes. Initial fresh-run evidence and current cached-input validation are recorded separately.

The review also examines original Cephes correspondence, MLX file history and official CC terms, and describes evidence needed for a grant, reviewed compliance route or separately reviewed implementation change. These lexical checks do not establish semantic equivalence or license scope. No additional grant or legal clearance is claimed.

No native code/pin/notice change, candidate cut or publication occurred. PR #100's native artifact/Gradle evidence remains historical; native implementation and legal findings are unchanged. The assistant posted no upstream issue or comment; the retained draft is historical and the owner submitted adapted wording.

Review packet: req/phase8-4-native-license-resolution.md.
Recipe and evidence: req/plans/evidence/native-license-resolution-2026-11-16/.

@perNyfelt
perNyfelt merged commit 102e03e into main Nov 16, 2026
3 checks passed
@perNyfelt
perNyfelt deleted the investigate-native-license-resolution branch November 16, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant