Review: check BIOS assets selected by the setup recipe - #24
Conversation
|
@cubic-dev-ai review this PR |
@Alexbeav I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
The correction and repeated validation are on 406451c; both initial findings have evidence replies and are resolved. Please review this current head before upstream submission. @cubic-dev-ai review this PR |
@Alexbeav I have started the AI code review. It will take a few minutes to complete. |
1 participant
A retail-only SDK currently fails staging when unused OpenBIOS files are absent. Read the staged
game.tomland require its selected BIOS profile. OpenBIOS-enabled recipes still require the OpenBIOS profile, image and license. Reject a missing recipe, missing selected profile or profile outside the staged kit.Ten source-owned synthetic tests cover the policy. The unchanged shell gate rejects a retail-only fixture for missing OpenBIOS; the checker passes the corrected fixture and rejects the negative controls. Run
python runtime/tests/test_setup_bios_assets.py.Fork review exposed a containment gap in default/OpenBIOS paths. Resolve every required path in the common gate before checking that it stays inside the kit. Six external file/directory symlink assertions fail before this correction; all ten tests pass afterward, with no symlink skips on the native Windows test host. Internal symlinks remain supported. The complete SDK stage, owned generation and runtime suite were repeated after this correction. The runtime source and generated bytes remain identical, so the exact previously built game executable is reused for the fresh isolated startup/normal-close check.
The complete
stage_setup_sdk.shalso passed with an actual retail-only SCPH1001 SDK and no OpenBIOS assets. The resulting SDK verified an owned disc, generated game and BIOS code, and built the native runtime. Emitters used documentedPSXRECOMP_STATIC_CLI=ONto avoid unrelated ambient MinGW DLL selection.This changes asset validation only. Current upstream's retail CLI generation still selects SCPH1001. Accepting an explicit SCPH5552 profile at the asset gate does not establish full SCPH5552 CLI support; that integration, including existing RetroPortingToolKit#243, remains separate. No retail BIOS is added to source or redistributed.
Validation and limits
8d56cf659fd84367c3f778e17851674ac7896371; review head:406451cb92da4d9f701c81b8271e420cef8677cc.474ec448d1fa040f21f121a99695ede07cfc362d893305813419269b535b70d5. This is bounded startup and normal shutdown, not gameplay completion or listening acceptance. Audio used SDL dummy output. No native Linux/macOS game route is claimed.dirty_text_continuation_guards,aot_overlay_discovery,release_zip) and three disabled tests. This branch does not change that recompiler source. Those baseline failures are not reported as passes.Scope and fork review
This review targets immutable
review-base/mstan-8d56cf659fd8. It contains 2 commit and 5 changed files. Do not merge it into the fork default branch; it is the review record before upstream submission.docs/SETUP_BIOS_ASSETS.md: behavior and verification documentation.runtime/CMakeLists.txt: source-owned regression and test registration.runtime/tests/test_setup_bios_assets.py: source-owned regression and test registration.tools/check_setup_bios_assets.py: bounded correction.tools/stage_setup_sdk.sh: bounded correction.Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.