Repository navigation
Conversation
Reader, search and listing requests now retry up to 4 times with a 3 s pause when the app hands back a Cloudflare challenge page instead of failing immediately. Manga updates error without retrying, and network errors are not retried.
kkantan
requested changes
Oct 18, 2026
kkantan
left a comment
kkantan
left a comment
Contributor
There was a problem hiding this comment.
I think this fix is a little odd for sources to implement. isn't this an app bug? If a user cancels a cloudflare challege, the source will continue to re-request and show popups multiple times, which seems to be undesirable behavior.
separately, I think we should avoid print statements in production sources. returning an error is sufficient since it is logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader, search and listing requests now retry up to 4 times with a 3 s pause when the app hands back a Cloudflare challenge page instead of failing immediately. Manga updates error without retrying, and network errors are not retried.
Refer #775, Aidoku/Aidoku#1107