test(authoring): use physical roots for mutation fixtures - #183
Draft
777genius wants to merge 2 commits into
Draft
test(authoring): use physical roots for mutation fixtures#183777genius wants to merge 2 commits into
777genius wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutation fixtures using raw temporary paths can hit a symlinked infrastructure ancestor before reaching the behavior they intend to test. Resolve only each newly owned fixture root before constructing destinations and intentional aliases, following the existing scaffold convention.
The six test files retain strict symlink rejection, source sentinels and transaction assertions. Add a real physical-root positive control and callback reachability checks so an early path/reader failure cannot masquerade as the expected injected failure. Production behavior is unchanged.
Stacked on #182 at 1643476. Delivery head 1dbd1b2 preserves both reviewed histories; the six fixture files exactly match reviewed 225c932, and README contracts exactly match the base. No merge conflicts or additional code changes.
Validation:
This is a bounded fixture correction, not exhaustive fixture conversion or native macOS qualification. Writable APFS packageview remains unproven, and existing raw-alias product semantics and platform gates remain unchanged. Useful legacy code, dependencies and tests are preserved. No public activation or release acceptance is claimed.
Artifact checks at the exact delivery head: all four native summaries and Go test streams were inspected, with matching revision/build identity for both entrypoints and five templates each. Windows had zero skips; each Linux run retained one optional-unproven Unix socket fixture. The packed archive passed independent verification of 7,662 indexed file hashes, 741 invocation records, 10 project inputs and 30 plans, with all phase exits zero. Archive verification covers recorded bytes/execution, not a relocated live-tree run. Release eligibility, platform acceptance and attestation remain false; writable macOS remains unproven.