Skip to content

test(authoring): use physical roots for mutation fixtures - #183

Draft
777genius wants to merge 2 commits into
fix/authoring-readme-contract-integrationfrom
test/authoring-physical-fixture-delivery
Draft

test(authoring): use physical roots for mutation fixtures#183
777genius wants to merge 2 commits into
fix/authoring-readme-contract-integrationfrom
test/authoring-physical-fixture-delivery

Conversation

@777genius

@777genius 777genius commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Mutation fixtures using raw temporary paths can hit a symlinked infrastructure ancestor before reaching the behavior they intend to test. Resolve only each newly owned fixture root before constructing destinations and intentional aliases, following the existing scaffold convention.

The six test files retain strict symlink rejection, source sentinels and transaction assertions. Add a real physical-root positive control and callback reachability checks so an early path/reader failure cannot masquerade as the expected injected failure. Production behavior is unchanged.

Stacked on #182 at 1643476. Delivery head 1dbd1b2 preserves both reviewed histories; the six fixture files exactly match reviewed 225c932, and README contracts exactly match the base. No merge conflicts or additional code changes.

Validation:

  • Independent gpt-6-astra medium review accepted the six-file patch with no introduced findings.
  • Independent scaffold, skills and commands package runs passed on Linux/Go 1.25.13: 352 PASS records including subtests, zero skips.
  • Exact composition checks and git diff --check passed; exact-head CI passed: Polyglot Smoke 34141566170 on Windows/Linux and Authoring native offline 34141566162, including all four native platforms, packed Linux amd64 and the required aggregate.

This is a bounded fixture correction, not exhaustive fixture conversion or native macOS qualification. Writable APFS packageview remains unproven, and existing raw-alias product semantics and platform gates remain unchanged. Useful legacy code, dependencies and tests are preserved. No public activation or release acceptance is claimed.

Artifact checks at the exact delivery head: all four native summaries and Go test streams were inspected, with matching revision/build identity for both entrypoints and five templates each. Windows had zero skips; each Linux run retained one optional-unproven Unix socket fixture. The packed archive passed independent verification of 7,662 indexed file hashes, 741 invocation records, 10 project inputs and 30 plans, with all phase exits zero. Archive verification covers recorded bytes/execution, not a relocated live-tree run. Release eligibility, platform acceptance and attestation remain false; writable macOS remains unproven.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant