feat(authoring): support quiescent writable APFS package reads - #186
Draft
777genius wants to merge 5 commits into
Draft
feat(authoring): support quiescent writable APFS package reads#186777genius wants to merge 5 commits into
777genius wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
The standard-first package reader needs writable ordinary local APFS support under the accepted quiescent-source contract. This change adds bounded ordered path resolution, thread-scoped materialization policy and explicit ownership/cleanup for the Darwin reader. The source and ancestor bindings must remain unchanged from Open through Close, including the Open/Capture gap. Hostile concurrent writers are outside this contract.
Stacked on #183 (
test/authoring-physical-fixture-delivery); do not retarget to main without rebasing the dependency stack. This is the reader/contracts checkpoint. Command integration, producer qualification and release activation remain later gates in the implementation plan.The shared post-open guard also preserves Windows native metadata registration: ordinary reads use the existing verified lease observation, while unknown metadata and hardlinks remain rejected.
Validation
178dfd823bb3cc083b2abc75bbc0752529a6826b: all GitHub checks passed, including native Linux/Windows amd64 and arm64, packed Linux, source acquisition and both polyglot smoke jobs. Windows artifacts were inspected: zero failure or skip records, with both new ordinary-read tests and the unchanged hardlink test passing on each architecture.Scope and remaining gates
Useful legacy YAML code, dependencies, tests and assets remain preserved. No YAML fallback or second engine is introduced. No public release or Pages activation is included.
The existing Windows parent-sharing gate remains unresolved. Device/dataless behavior, advertised macOS floor, ambient policy interaction, producer and CLI release qualification are not established by the focused native results. These limits must remain explicit before release.
Review size is 2,366 changed lines across 26 files, slightly above the 2,000-line target. The reader contract, resolver, scoped I/O policy and causal cleanup tests form one coherent acquisition invariant; splitting them would leave intermediate behavior unsupported. Most additions are focused tests and contract documentation.