Skip to content

Guard settings destructure so the settings page doesn't blank when classifAISettings is missing #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkotter merged 3 commits into from
Jul 7, 2026
+12 −1
Merged

Guard settings destructure so the settings page doesn't blank when classifAISettings is missing #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234b7ea
Guard settings destructure so the settings page doesn't blank when cl…
thisismyurl Jul 7, 2026
53dd709
Add PR number to changelog entry (#1135)
thisismyurl Jul 7, 2026
0615f0d
Render nothing when there are no features to route to
thisismyurl Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file, per [the Ke

## [Unreleased] - TBD

### Fixed

- Settings page no longer crashes to a blank screen when `window.classifAISettings` is undefined (for example when a caching or optimization plugin changes script order); the settings data is now read defensively (props [@thisismyurl](https://github.com/thisismyurl) via [#1135](https://github.com/10up/classifai/pull/1135)).

@dkotter dkotter Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we generally don't include changelog entries in each PR as those are manually pulled at release time


## [3.8.0] - 2026-03-20

### Added
Expand Down
9 changes: 8 additions & 1 deletion src/js/settings/components/classifai-settings/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { ClassifAIRegistration } from '../classifai-registration';
import { ClassifAIWelcomeGuide } from './welcome-guide';
import { Notices } from '../feature-settings/notices';

const { services, features } = window.classifAISettings;
const { services = {}, features = {} } = window.classifAISettings || {};
Comment thread
dkotter marked this conversation as resolved.

/**
* FeatureSettingsWrapper component to render the feature settings.
Expand All @@ -43,6 +43,13 @@ const FeatureSettingsWrapper = () => {
const { service, feature } = useParams();
const serviceFeatures = Object.keys( features[ service ] || {} );

// When the settings data is unavailable (for example the global was
// missing) there is no feature to route to, so render nothing rather than
// navigating to an undefined path.
if ( ! serviceFeatures.length ) {
return null;
}

if ( ! serviceFeatures.includes( feature ) ) {
return <Navigate to={ serviceFeatures[ 0 ] } replace />;
}
Expand Down
Loading