Guard settings destructure so the settings page doesn't blank when classifAISettings is missing

[thisismyurl]

Hey folks,

If window.classifAISettings is ever undefined when the settings bundle loads, the whole settings screen goes blank with nothing but a console error to explain it. The cause is the module-scope destructure at the top of classifai-settings/index.js — const { services, features } = window.classifAISettings; runs the moment the module is imported, before React mounts, so there's no error boundary between it and the user. Anything that shifts script order or timing (a caching or optimization plugin deferring or reordering the enqueue, an asset that fails to localize) leaves the global undefined and that line throws a TypeError that takes the page down.

This PR guards just that destructure: default services and features to {} and fall back to {} when the global is missing. The downstream code already treats these defensively (features[ service ] || {}), so an empty object degrades into an empty settings shell instead of a white screen. The issue also floats a React error boundary and a NitroPack exclusion; I kept this change to the one-line guard that stops the crash, since those are larger design calls that deserve their own discussion. Glad to follow up on either if you want them.

One thing worth flagging plainly: an automated regression test here is awkward. There's no JS unit harness (only PHP unit and the Playwright e2e suite), and the e2e environment always localizes window.classifAISettings, so a test would have to force the failure synthetically — aborting or blanking the settings script via page.route before mount — to reproduce the undefined-global state. Your e2e suite already uses page.route for that kind of interception, so I'm glad to add that guard if you'd like it; I held off because it exercises a forced condition rather than a natural one, and the change itself is a defensive default with no behavior change when the global is present. Your call.

No rendered-UI change comes with this — the guard only affects the crash path when the global is absent, so there's no accessibility surface to review.

Closes #1073

(full disclosure: AI helped me identify the issue and verify my work)

[Copilot]

Pull request overview

This PR defensively reads the settings bootstrap data (window.classifAISettings) so the React-based settings UI doesn’t hard-crash at module import time when that global is missing (e.g., due to script reordering/deferral).

Changes:

• Guard module-scope destructuring of window.classifAISettings by falling back to {} defaults.
• Add an [Unreleased] changelog entry documenting the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/js/settings/components/classifai-settings/index.js	Prevents a module-load TypeError by defaulting services/features when the global settings object is missing.
CHANGELOG.md	Documents the fix under [Unreleased].

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[dkotter]

Note we generally don't include changelog entries in each PR as those are manually pulled at release time

[thisismyurl]

Good catch — that's a real gap. The guard stopped the module-scope crash but left FeatureSettingsWrapper free to navigate to serviceFeatures[0] when features is empty, landing on to={undefined} — exactly the broken route this was meant to prevent. Pushed a small follow-up (0615f0d) that returns null when there's no feature to route to.

On the changelog note: the #1135 link is correct — that placeholder line was left over from before the PR number existed, and I've removed it from the description.