Repository navigation
feat: make boot animation theme fallback explicit - #109
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Make the boot-animation input contract explicit and theme-safe:
custom/boot-animation/bootanimation.zipexists, use it for both light and dark runtime paths;bootanimation-dark.zipexists, use it for both;The repository currently contains only
bootanimation.zip, so today's effective result is intentionally duplicated to both:product.img:/media/bootanimation.zipproduct.img:/media/bootanimation-dark.zipThis keeps the product-image-root fix from PR #108.
Verification
product-image-root-theme-fallback-stored-v5.Diagnosis note
The lack of a checked-in dark ZIP was not the cause of the previously published failure: the previous adapter already copied the single source payload to both runtime filenames. The nested product-image path fixed by PR #108 was independently sufficient to make both copies invisible at runtime.
This change formalizes the intended one-file/two-file behavior so future theme-specific payloads work predictably.