Skip to content

feat: make boot animation theme fallback explicit - #109

Merged
0cwa merged 8 commits into
mainfrom
fix/boot-animation-theme-fallback-20260925
Sep 25, 2026
Merged

0cwa merged 8 commits into
mainfrom
fix/boot-animation-theme-fallback-20260925

Conversation

@0cwa

@0cwa 0cwa commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Behavior

Make the boot-animation input contract explicit and theme-safe:

  • if only custom/boot-animation/bootanimation.zip exists, use it for both light and dark runtime paths;
  • if only bootanimation-dark.zip exists, use it for both;
  • if both exist, preserve the two distinct animations;
  • if neither exists while the feature is enabled, fail closed.

The repository currently contains only bootanimation.zip, so today's effective result is intentionally duplicated to both:

  • product.img:/media/bootanimation.zip
  • product.img:/media/bootanimation-dark.zip

This keeps the product-image-root fix from PR #108.

Verification

  • validate both resolved source roles;
  • canonicalize each independently to Android-compatible ZIP_STORED;
  • finished-OTA verification compares light and dark output against their resolved source payloads;
  • selection identity hashes both effective theme roles and bumps the adapter contract to product-image-root-theme-fallback-stored-v5.

Diagnosis note

The lack of a checked-in dark ZIP was not the cause of the previously published failure: the previous adapter already copied the single source payload to both runtime filenames. The nested product-image path fixed by PR #108 was independently sufficient to make both copies invisible at runtime.

This change formalizes the intended one-file/two-file behavior so future theme-specific payloads work predictably.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4411d3e9-3f3f-46fb-ab38-91d40c5595a7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0cwa
0cwa merged commit 27ec83c into main Sep 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant