Repository navigation
fix: label product-relative boot animation paths correctly - #110
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure found by force-publish
The first force-publish attempt after PR #109 failed before publication with:
ExtInstallError: no file_contexts label matches installation path: /media/bootanimation.zipThat reveals a path-model mismatch in the pinned helper:
/media/...);file_contextspatterns are runtime Android paths (/product/media/...).Using
/product/media/...directly with ExtFs creates the wrong filesystem path, while using/media/...without a context alias cannot create a new inode.Fix
Keep the correct partition-relative product image paths and add only exact context aliases for:
/media/media/bootanimation.zip/media/bootanimation-dark.zipEach alias derives its label from the corresponding runtime
/product/...path using the helper's loaded contexts. If GrapheneOS no longer has a runtime context matching the expected product path, the build fails closed.No SELinux policy is modified, no broad regex is added, no bootanimation binary is patched, and the adapter still writes only through ExtFs.
The theme fallback from PR #109 remains:
The selection contract is bumped to
product-image-root-theme-context-stored-v6.