Load workspace config when indexing tracked repos#17
Open
Load workspace config when indexing tracked repos#17
Conversation
d1446fb to
bdba63c
Compare
Load each tracked repo's .gortex.yaml before IndexAll builds its per-repo Indexer. This makes server --track honor repo-local excludes and other workspace config without treating the workspace config as global state.\n\nCo-Authored-By: Mastra Code (openai/gpt-5.5) <noreply@mastra.ai>
bdba63c to
61e095d
Compare
Owner
|
Hey @alex4o! Thank you for catching this nasty bug and contribution. I followed further for the change and found MultiIndexer.IndexRepo at gortex/internal/indexer/multi.go Line 359 in a296103 It's reached from the MCP index_repository tool gortex/internal/mcp/tools_core.go Line 552 in a296103 Also, tests only cover the exclude symptom and they don't lock down the workspace-slug propagation, which is the other (and arguably more impactful) thing your fix unblocks. Adding a workspace-slug assertion would harden against regressions.
Can you please take a look to those cases? If you don't have time for it - I can accept the PR and apply those patches in the follow up commit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gortex.yamlbeforeIndexAllcreates its per-repo indexerserver --trackhonor repo-local excludes and workspace config from the tracked destination repoIndexAllrespecting workspace excludesTest plan
go test ./cmd/gortex ./internal/config ./internal/indexer ./internal/excludesgo build -o gortex ./cmd/gortex