fix codegen client compatibility - #1
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
fergusean
marked this pull request as ready for review
July 21, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestResultso async request wrappers return one promise of the possible result shapesRoot cause
The legacy client generator selected multipart encoding for endpoints that also accepted JSON, causing nested request fields to arrive as strings unless a file activated the
_payloadupload adapter. The current generator selects JSON when the optional upload is omitted. During the consumer upgrade, the v2.9.0RequestResultconditional type also exposed an incompatible union-of-promises shape for normal async wrappers.Validation
yarn formatyarn lintyarn test:typecheckyarn build