fix(persistence): strict type validation for location/weather from localStorage#5
Draft
fix(persistence): strict type validation for location/weather from localStorage#5
Conversation
…dation Co-authored-by: rdtect <31343717+rdtect@users.noreply.github.com> Agent-Logs-Url: https://github.com/zyetaone/swa_window/sessions/29dc6d06-9e58-43f5-80ad-8135018c6e6e
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on type validation for JSON from localStorage
fix(persistence): strict type validation for location/weather from localStorage
Mar 24, 2026
Base automatically changed from
security-fix-load-persisted-state-validation-13195613228722407853
to
main
March 24, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truthiness checks on
parsed.locationandparsed.weatherallowed falsy invalid values ('',0,false) to bypass validation and persist into app state.Changes
src/lib/core/persistence.ts: Replace truthiness guards with!== undefined+ explicittypeof === 'string'checks before set/array membership tests; delete the key on any type mismatch or unrecognised value.Same pattern applied to
parsed.weather. Consistent with how boolean flags are already validated in the same function.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.