Repository navigation
fix(audit): prevent scans crashing on non-import provider bindings - #267
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
FactoryLine Proof ReviewCommit: Changed-scope walkthrough
Fact-derived next action
Findings
Unproven claims
Authority boundaryAdvisory only. This payload has no execution, approval, publication, deployment, signing, messaging, credential, connector, source write, test execution, repair authority. It does not use CodeRabbit credentials, interpret AI comments as proof, approve, merge, or modify source. Existing Diff-to-Proof mapflowchart LR
REVIEW["Diff-to-Proof Review"]
C1["Changed: factoryline/credential_role_constructor_provider.py"]
C1 --> REVIEW
C2["Changed: plans/shared-security-evidence.md"]
C2 --> REVIEW
C3["Changed: tests/test_credential_constructor_cache.py"]
C3 --> REVIEW
U1["Unmatched: factoryline/credential_role_constructor_provider.py"]
REVIEW --> U1
U2["Unmatched: plans/shared-security-evidence.md"]
REVIEW --> U2
U3["Unmatched: tests/test_credential_constructor_cache.py"]
REVIEW --> U3
F1["unmatched_changed_path"]
REVIEW --> F1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A normal security scan could crash when a shadowed provider name was represented by a non-import AST binding. The shared namespace resolver now rejects those bindings before reading import-specific fields; valid import resolution stays unchanged.
Validation: six reproduced crash shapes now pass; all 240 affected constructor/provider tests pass. The previously failing captured repository passes the public CLI and unchanged independent receipt verifier. Ruff, C901, formatting, strict architecture and hash-bound workflow audit pass. No new recognizer, helper, module, dependency or cap change. The original frozen baseline remains recorded as incomplete; this is not a precision claim.
Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high. Sol verdict: approved.
Created with Codex.