Repository navigation
Validate Django session authority with measured TP admission and CI repairs - #264
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
FactoryLine Proof ReviewCommit: Changed-scope walkthrough
Fact-derived next action
Findings
Unproven claims
Authority boundaryAdvisory only. This payload has no execution, approval, publication, deployment, signing, messaging, credential, connector, source write, test execution, repair authority. It does not use CodeRabbit credentials, interpret AI comments as proof, approve, merge, or modify source. Existing Diff-to-Proof mapflowchart LR
REVIEW["Diff-to-Proof Review"]
C1["Changed: .github/workflows/signed-receipts.yml"]
C1 --> REVIEW
C2["Changed: docs/evidence/native-session-admission-20261031.json"]
C2 --> REVIEW
C3["Changed: editors/vscode/package-lock.json"]
C3 --> REVIEW
C4["Changed: editors/vscode/package.json"]
C4 --> REVIEW
C5["Changed: factoryline/credential_endpoint_admission.py"]
C5 --> REVIEW
C6["Changed: factoryline/primitive_observation_binding.py"]
C6 --> REVIEW
C7["Changed: factoryline/semantic_credential_sensor.py"]
C7 --> REVIEW
C8["Changed: plans/shared-security-evidence.md"]
C8 --> REVIEW
C9["Changed: tests/test_context_efficiency.py"]
C9 --> REVIEW
C10["Changed: tests/test_publication_metadata.py"]
C10 --> REVIEW
C11["Changed: tests/test_semantic_credential_sensor.py"]
C11 --> REVIEW
C12["Changed: tests/test_signed_receipts.py"]
C12 --> REVIEW
U1["Unmatched: .github/workflows/signed-receipts.yml"]
REVIEW --> U1
U2["Unmatched: docs/evidence/native-session-admission-20261031.json"]
REVIEW --> U2
U3["Unmatched: editors/vscode/package-lock.json"]
REVIEW --> U3
U4["Unmatched: editors/vscode/package.json"]
REVIEW --> U4
U5["Unmatched: factoryline/credential_endpoint_admission.py"]
REVIEW --> U5
U6["Unmatched: factoryline/primitive_observation_binding.py"]
REVIEW --> U6
U7["Unmatched: factoryline/semantic_credential_sensor.py"]
REVIEW --> U7
U8["Unmatched: plans/shared-security-evidence.md"]
REVIEW --> U8
U9["Unmatched: tests/test_context_efficiency.py"]
REVIEW --> U9
U10["Unmatched: tests/test_publication_metadata.py"]
REVIEW --> U10
U11["Unmatched: tests/test_semantic_credential_sensor.py"]
REVIEW --> U11
U12["Unmatched: tests/test_signed_receipts.py"]
REVIEW --> U12
F1["unmatched_changed_path"]
REVIEW --> F1
|
zrk222
enabled auto-merge
October 31, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django signing-key diagnostics stayed unresolved even when captured startup selected the configuration and authentication/session consumers were configured. This change joins that existing source evidence into native session-authority admission while preserving every original diagnostic.
Admission requires current source hashes, exact consumer settings and stable framework providers. Missing, overwritten, aliased or mutated settings, placeholder material, local framework shadows and unresolved distribution scope remain NEEDS_CONTEXT. Existing provider validators are reused; duplicated parent traversal and three single-use projections are removed. No module, dependency or architecture budget is added to the scanner.
Measured TP admission gain
The committed source-bound evidence at
docs/evidence/native-session-admission-20261031.jsonrecords the unchanged 90-label Study430 exposed panel across 67 repositories:This is an admission gain on exposed data, not five newly discovered/labeled TPs or a fresh held-out precision percentage. Raw labels remain 15 TP / 53 FP / 22 UNCLEAR; ten known TPs remain outside the supported tier. Baseline tiers came from retained reports rather than a freshly rerun baseline commit. The replay completed in 82.3 seconds; source, label and measurement hashes are recorded. The >=30-decided fresh acceptance and >=80% target remain unmet. Labels are AI-only; disagreements remain UNCLEAR. No release/publication claim is made.
CI repairs in this candidate
a34deb92; hosted OIDC verification remains a post-merge check.Validation
220 affected session-family controls, 12 additional inventory/cache controls, repaired metadata/capacity checks and 51 final receipt/capacity controls passed. Native CLI output, persisted receipt readback, independent resealing and tampered-source rejection were exercised. Ruff, format, C901, strict architecture (133 core modules), immutable action pins and the final hash-bound workflow audit passed.
Independent Backend Architect AI review found no P0/P1 issues in the receipt retry and capacity optimization and reproduced provider-metadata controls. No external human review is claimed. Source/workflow, tests and measurement evidence are in separate commits. PR #265 is superseded by the consolidated CI repairs here. Current hosted required checks must pass before a regular merge; main-tip CI and signing must be verified afterward.