Fix CSS handling flow #2
Merged
Merged
Conversation
added 2 commits
July 19, 2021 23:03
Include CSS in merged stylesheets if options.css == false. This is in accordance with the purpose of the original Svelte compiler config `css`, which in essence determines if the CSS should be part of the component's JS or output as CSS to be included in a static stylesheet somewhere.
arggh
commented
Jul 20, 2021
It is now compatible with both version before and after 3.30.0 sveltejs/svelte#5584
Owner
|
Thanks @arggh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a somewhat working proof of concept as a result of me tinkering with the plugin (in case it might be useful).
css: false➡️ All compiled Svelte components' CSS in merged into the stylesheetscss: true➡️ CSS is included in the component codeCaching seems a bit broken, if I change from
css: falsetocss: true, all styles are missing until ameteor reset.