Skip to content

Bump to rust-random 0.9#56

Merged
str4d merged 1 commit into
zkcrypto:release-0.14.0from
pinkforest:bump-rand-0.9
Apr 16, 2025
Merged

Bump to rust-random 0.9#56
str4d merged 1 commit into
zkcrypto:release-0.14.0from
pinkforest:bump-rand-0.9

Conversation

@pinkforest

@pinkforest pinkforest commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@pinkforest pinkforest mentioned this pull request Jan 28, 2025
Closed
@pinkforest pinkforest force-pushed the bump-rand-0.9 branch 2 times, most recently from c7e8495 to 06ac6fb Compare February 3, 2025 13:18
@tarcieri tarcieri mentioned this pull request Feb 12, 2025
Closed
4 tasks
@baloo baloo mentioned this pull request Feb 14, 2025
Merged
tarcieri pushed a commit to RustCrypto/traits that referenced this pull request Feb 23, 2025
@baloo
elliptic-curve: bump rand_core to 0.9.0 (#1751)
fbb4321 
This pulls:
 - RustCrypto/crypto-bigint#762
 - RustCrypto/crypto-bigint#765
 - zkcrypto/ff#122
 - zkcrypto/group#56
 - RustCrypto/MACs#178
 - RustCrypto/formats#1666
@baloo baloo mentioned this pull request Feb 23, 2025
Merged
@baloo baloo mentioned this pull request Mar 3, 2025
Merged
@str4d

str4d commented Mar 9, 2025

Copy link
Copy Markdown
Member

ff side is ready for a preview release (zkcrypto/ff#133); I'll work on the group side next.

@str4d str4d changed the base branch from main to release-0.14.0 April 16, 2025 12:26
str4d
str4d requested changes Apr 16, 2025
View reviewed changes
Comment thread rust-toolchain Outdated
@@ -1 +1 @@
1.56.0
1.66.0

@str4d str4d Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is insufficient to produce an MSRV bump. I have done this in a separate PR (#62).

Also, MSRV 1.66 is a false MSRV, because it is possible to pin to blake2b_simd 1.0.0 (if using ff_derive) in order to avoid the constant_time_eq bumps (and these are only dev-dependencies anyway). There's no need to raise MSRV beyond what rand forces.

@pinkforest @str4d
Bump to rust-random 0.9
055cc14 
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
@str4d

str4d commented Apr 16, 2025

Copy link
Copy Markdown
Member

Rebased on release-0.14.0 to replace the incomplete MSRV bump in this PR, add the missing ff patch, add the missing changelog update, and bring in the updated CI.

str4d
str4d approved these changes Apr 16, 2025
View reviewed changes

@str4d str4d left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 055cc14

@str4d str4d merged commit 42e0ad5 into zkcrypto:release-0.14.0 Apr 16, 2025
@str4d str4d mentioned this pull request Apr 16, 2025
Closed
@baloo baloo mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@str4d str4d str4d approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump rand + rand_core

2 participants

@pinkforest @str4d