ci: pass VERSION_STR to publish job and fix Slack Docker tag#55
Merged
Conversation
The release workflow computed VERSION_STR in check_release_requirements.sh but never exposed it as a job output or forwarded it to the publish job, so publish-docker-image.sh saw an empty tag and failed with "invalid reference format" (e.g. vflow-node: on the v2.0.0-rc1 release). Expose VERSION_STR as a check-requirements output and pass it into the publish step, mirroring the zkVerify workflow. Also switch the Slack Docker Hub tag link and docker pull command from github.ref_name (v-prefixed) to the v-stripped version-str, matching the actual pushed image tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
davehorizen
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v2.0.0-rc1release failed at the Docker publish step:The tag after the colon was empty.
check_release_requirements.shcomputesVERSION_STR(thev-stripped tag, e.g.2.0.0-rc1) and correctly detected the RC release, but the workflow never exposedVERSION_STRas a job output nor forwarded it to the publish job. Sopublish-docker-image.shread an emptyVERSION_STR, producing an emptydocker_tag_fulland thevflow-node:reference.Fix
Mirror the zkVerify
CI-release.ymlwiring:version-stroutput to thecheck-requirementsjob.echo "VERSION_STR=..." >> "$GITHUB_OUTPUT"in the check step.VERSION_STRinto thepublish-docker-imagestep env.Also fix a related
v-prefix mismatch in the Slack notification: the Docker Hub tag link anddocker pullcommand usedgithub.ref_name(v2.0.0-rc1), but the pushed image tag has nov(2.0.0-rc1). Both now use thev-strippedversion-str, matching the actual image. The GitHub releasetag_nameintentionally keepsgithub.ref_name(the GitHub tag keeps thev).Result
v2.0.0-rc1now publishes asvflow-node:2.0.0-rc1, and the Slackdocker pullcommand references a tag that actually exists.🤖 Generated with Claude Code