Skip to content

Before generate a mainnet release x.y.z we should che if testnet release x.y.z tag is the same as mainnet.#51

Merged
drgora merged 2 commits into
mainfrom
md/ci-release-mainet-only-if-a-testnet-exists
Jul 9, 2026
Merged

Before generate a mainnet release x.y.z we should che if testnet release x.y.z tag is the same as mainnet.#51
drgora merged 2 commits into
mainfrom
md/ci-release-mainet-only-if-a-testnet-exists

Conversation

@la10736

@la10736 la10736 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@la10736 la10736 requested review from 95DDB, drgora and ysibirski January 15, 2026 15:43

@ysibirski ysibirski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drgora drgora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, which looks good to me. But on this repo we use the mainnet tag, and not zkverify, for the mainnet tags.

Comment thread ci/check_runtime_requirements.sh Outdated
Comment thread ci/check_runtime_requirements.sh Outdated
Comment thread ci/check_runtime_requirements.sh Outdated
@la10736 la10736 force-pushed the md/ci-release-mainet-only-if-a-testnet-exists branch from 20ae3e0 to a86e97f Compare January 16, 2026 14:37
@drgora drgora force-pushed the md/ci-release-mainet-only-if-a-testnet-exists branch from a86e97f to eba1a6f Compare July 9, 2026 14:58

@drgora drgora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the remaining comments

@drgora drgora merged commit 5f80515 into main Jul 9, 2026
13 checks passed
@drgora drgora deleted the md/ci-release-mainet-only-if-a-testnet-exists branch July 9, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants