fix(config): strip schema property defaults at every level - #784
Draft
vitorbari wants to merge 1 commit into
Draft
fix(config): strip schema property defaults at every level#784vitorbari wants to merge 1 commit into
vitorbari wants to merge 1 commit into
Conversation
normalizeSchemaBody only walked the top level, so a default carried by a leaf of an object property survived normalization and showed up as a permanent phantom diff. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🦋 Changeset detectedLatest commit: c0f42c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeSchemaBodyonly walked the top level, so a default carried by a leaf of an objectproperty survived normalization — a nested
x-editable: trueproduced a permanent phantom diff.Validation
moon run config:test config:typecheck config:lintRelease notes / changeset
.changeset/normalize-nested-schema-defaults.md— patch for@zitadel/config.Notes