convert GrpcIndexer to be a #73
Merged
zancas merged 7 commits intoMay 12, 2026
Merged
Conversation
… drop in replacement for CompactTxStreamerClient in consumers such as Pepper-sync
zancas
reviewed
May 11, 2026
zancas
reviewed
May 11, 2026
zancas
changed the title
zancas
approved these changes
May 12, 2026
Member
|
Breadcrumb... think about abstracting network concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… drop in replacement for CompactTxStreamerClient in consumers such as Pepper-sync
as mentioned in the description, the GrpcIndexer in it current form is not suitable to pass to pepper-sync due to unnecessary client creation for each rpc call. there is also an issue with drop-in replacement of CompactTxStreamClient with GrpcIndexer due to an extra layer of errors that are not needed if the client is generated initially and reused for all rpc calls. This work is especailly important to implement nym for zingolib/pepper-sync as the GrpcIndexer will hold two clients (surface net and nym) that will both need to be passed into pepper-sync in the form of the GrpcIndexer struct