Fix document handler cleanup for cancelled and unmounted slider interactions - #330
Draft
hexmarkrecords wants to merge 2 commits into
Draft
hexmarkrecords wants to merge 2 commits into
hexmarkrecords wants to merge 2 commits into
Conversation
…tive-document-handlers-on-unmount-and-handle-touch-cancellation fix(react-slider): clean up document handlers on interrupted touch drags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cleanup of document-level interaction handlers when a slider interaction is interrupted.
componentWillUnmount.touchcancelsupport and cleans up active touch handlers when it fires.preventDefault()fortouchendonly when the event is cancelable.Why
The slider registers document-level handlers while an interaction is active. If the component unmounts before the usual end event, those handlers were not removed. Touch interactions can also be interrupted without a
touchendevent.This change ensures handlers are cleaned up in both cases without changing normal slider behavior.
Tests
Added coverage for:
touchcancel.preventDefault()for non-cancelabletouchendevents.Verification
npm test -- --runInBand src/components/ReactSlider/__tests__/ReactSlider.test.jsnpm run eslint -- --no-fix